Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICON enum in Interop User32 #3004

Merged
merged 1 commit into from Mar 23, 2020
Merged

Add ICON enum in Interop User32 #3004

merged 1 commit into from Mar 23, 2020

Conversation

@gpetrou
Copy link
Contributor

gpetrou commented Mar 22, 2020

Proposed changes

  • Add ICON enum in Interop User32.
  • Remove ICON constants and replace their usages with the above enum values.
Microsoft Reviewers: Open in CodeFlow
@gpetrou gpetrou requested a review from dotnet/dotnet-winforms as a code owner Mar 22, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #3004 into master will increase coverage by 0.00703%.
The diff coverage is 25.00000%.

@@                 Coverage Diff                 @@
##              master       #3004         +/-   ##
===================================================
+ Coverage   62.15665%   62.16368%   +0.00703%     
===================================================
  Files           1257        1257                 
  Lines         449429      449428          -1     
  Branches       39227       39227                 
===================================================
+ Hits          279350      279381         +31     
+ Misses        164604      164576         -28     
+ Partials        5475        5471          -4     
Flag Coverage Δ
#Debug 62.16368% <25.00000%> (+0.00703%) ⬆️
#production 33.36255% <25.00000%> (+0.01243%) ⬆️
#test 98.98504% <ø> (ø)
@RussKie RussKie merged commit 0e265d8 into dotnet:master Mar 23, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
dotnet-winforms CI Build #20200322.1 succeeded
Details
dotnet-winforms CI (Build Windows Debug) Build Windows Debug succeeded
Details
dotnet-winforms CI (Build Windows Release) Build Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
@msftbot msftbot bot added this to the 5.0 milestone Mar 23, 2020
@RussKie RussKie added the enhancement label Mar 23, 2020
M-Lipin added a commit to M-Lipin/winforms that referenced this pull request Mar 23, 2020
@gpetrou gpetrou deleted the gpetrou:ICON branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.