New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead DataGridViewCell/Row null checks #312

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@hughbe
Copy link
Contributor

hughbe commented Jan 10, 2019

No description provided.

@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Jan 10, 2019

@@ -228,7 +228,7 @@ public virtual bool Displayed
return false;
}

if (this.DataGridView != null && this.RowIndex >= 0 && this.ColumnIndex >= 0)

This comment has been minimized.

@hughbe
@@ -499,7 +499,7 @@ public override bool Visible
{
dataGridViewAdvancedBorderStylePlaceholder.TopInternal = DataGridViewAdvancedCellBorderStyle.None;
}
if (this.DataGridView != null && this.DataGridView.RightToLeftInternal)
if (this.DataGridView.RightToLeftInternal)

This comment has been minimized.

@JuditRose
Copy link
Member

JuditRose left a comment

LGTM

@zsd4yr zsd4yr merged commit dd5eb7f into dotnet:master Jan 14, 2019

1 check passed

license/cla All CLA requirements met.
Details

@hughbe hughbe deleted the hughbe:dead-null-checks branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment