New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOC CHECKIN | dotnet/winforms master | 20190131 #402

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@v-zbsail
Copy link
Contributor

v-zbsail commented Jan 31, 2019

No description provided.

@v-zbsail v-zbsail requested a review from dotnet/dotnet-winforms as a code owner Jan 31, 2019

@janbaltus

This comment has been minimized.

Copy link

janbaltus commented Jan 31, 2019

Please wait with merge till 2/1. We neeed to update PR with fully localized xlf

@karelz karelz added the * NO-MERGE * label Jan 31, 2019

@karelz

This comment has been minimized.

Copy link
Member

karelz commented Jan 31, 2019

@janbaltus marking as "NO MERGE" per your request

@janbaltus

This comment has been minimized.

Copy link

janbaltus commented Feb 1, 2019

@karelz please merge now. PR is updated

@KlausLoeffelmann

This comment has been minimized.

Copy link
Member

KlausLoeffelmann commented Feb 1, 2019

Hey Jan, good to see you here! The world is small, is it not? 😄

Can you take a look at my review of the German part?
There was one wrong translation, and one that was kind of off.

Thanks! See you around!

@karelz karelz removed the * NO-MERGE * label Feb 1, 2019

@karelz

This comment has been minimized.

Copy link
Member

karelz commented Feb 1, 2019

"No merge" removed, I let merging on WinForms team members :) (pending code review changes based on Klaus's CR feedback)

@zsd4yr

zsd4yr approved these changes Feb 1, 2019

@zsd4yr zsd4yr merged commit 2c0c1cf into dotnet:master Feb 1, 2019

1 check passed

license/cla All CLA requirements met.
Details
@janbaltus

This comment has been minimized.

Copy link

janbaltus commented Feb 4, 2019

Hi @KlausLoeffelmann, we are triaging your comments and we will implement them and export by end of this week.
Thank you,
Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment