New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for binary log being clobbered by later steps #408

Merged
merged 4 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@zsd4yr
Copy link
Member

zsd4yr commented Feb 1, 2019

This is a fix for the clobbering of the binary log by later phases of the build jobs; this is currently done on the eng/common version which will be overridden the next time that we take an update from arcade. I will circle around and see if they want to add this feature or if we will have to step away and maintain our own co0py of the script (not ideal)

@zsd4yr zsd4yr requested a review from dotnet/dotnet-winforms as a code owner Feb 1, 2019

@zsd4yr zsd4yr requested review from AdamYoblick , Tanya-Solyanik and mmitche Feb 1, 2019

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik left a comment

Hi @zsd4yr Is there a way to run CI build locally and test this change?

zsd4yr added some commits Feb 4, 2019

@zsd4yr zsd4yr merged commit 02fd47f into master Feb 4, 2019

1 check passed

license/cla All CLA requirements met.
Details

@zsd4yr zsd4yr deleted the dev/zadanz/binaryLogBug branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment