New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link pointing to contributing.md #413

Merged
merged 2 commits into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@manuelvalenzuela
Copy link
Contributor

manuelvalenzuela commented Feb 7, 2019

No description provided.

@manuelvalenzuela manuelvalenzuela requested a review from dotnet/dotnet-winforms as a code owner Feb 7, 2019

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 7, 2019

Hey @manuelvalenzuela thanks for the contribution here 😄 Is there a way to point to this document without requiring it be the blob on master? For instance, this link should point to the version of this document in whichever branch it is in, not always master.

@manuelvalenzuela

This comment has been minimized.

Copy link
Contributor Author

manuelvalenzuela commented Feb 7, 2019

o

Hi @zsd4yr!! you're welcome!. I think the link is independent of the branch right now, is just a relative link (the only line I changed was 28)

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 8, 2019

Hi @zsd4yr!! you're welcome!. I think the link is independent of the branch right now, is just a relative link (the only line I changed was 28)

@manuelvalenzuela I think I would prefer if it was dependent on the branch

@manuelvalenzuela

This comment has been minimized.

Copy link
Contributor Author

manuelvalenzuela commented Feb 8, 2019

You're right, I will do it now.

@merriemcgaw

This comment has been minimized.

Copy link
Member

merriemcgaw commented Feb 8, 2019

@manuelvalenzuela thanks for the contribution!

@manuelvalenzuela

This comment has been minimized.

Copy link
Contributor Author

manuelvalenzuela commented Feb 8, 2019

@manuelvalenzuela thanks for the contribution!

@merriemcgaw glad to do it! this is just a preheating! :D

@zsd4yr

zsd4yr approved these changes Feb 11, 2019

Copy link
Member

zsd4yr left a comment

LGTM :)

@zsd4yr zsd4yr merged commit 553a43b into dotnet:master Feb 11, 2019

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment