New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ResourceExposure/ResourceConsumption attributes #419

Merged
merged 19 commits into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@zacpwhite
Copy link
Contributor

zacpwhite commented Feb 8, 2019

Remove the obsolete ResourceExposure / ResourceConsumption attributes as outlined in #321

Removed ResourceExposure/ResourceConsumption attributes
Remove the obsolete ResourceExposure / ResourceConsumption attributes from all files

@zacpwhite zacpwhite requested a review from dotnet/dotnet-winforms as a code owner Feb 8, 2019

@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Feb 8, 2019

CLA assistant check
All CLA requirements met.

public static extern int RevokeDragDrop(IntPtr hwnd);

[ResourceExposure(ResourceScope.None)]

This comment has been minimized.

@zsd4yr

zsd4yr Feb 8, 2019

Member

nit: some of these changes remove the attribute declaration as well as the rest of the line, while others keep the line. Could we choose either and be consistent? I think deleting the line would be a little cleaner.

@@ -14,95 +14,95 @@ namespace System.Windows.Forms.Design
internal class UnsafeNativeMethods
{
[DllImport(ExternDll.User32, ExactSpelling = true, CharSet = CharSet.Auto)]
[ResourceExposure(ResourceScope.None)]

This comment has been minimized.

@zsd4yr

zsd4yr Feb 8, 2019

Member

Here the line was kept.

zacpwhite added some commits Feb 9, 2019

Removed unnecessary lines
Remove unnecessary lines leftover from removal of obsolete Resource attributes
Removed unnecessary lines
Removed unnecessary lines leftover from removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines leftover from removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines leftover from removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines leftover from removal of Resource attributes
General formatting cleanup
- Removed unnecessary lines leftover from removal of Resource attributes
- Formatted attributes
Removed unnecessary lines
Removed unnecessary lines leftover from removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
- Removed unnecessary lines after removal of Resource attributes
- General formatting
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
Removed unnecessary lines
Removed unnecessary lines after removal of Resource attributes
@zsd4yr

zsd4yr approved these changes Feb 11, 2019

@zsd4yr zsd4yr merged commit 15cda68 into dotnet:master Feb 11, 2019

1 check passed

license/cla All CLA requirements met.
Details
@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 11, 2019

thank you @zacpwhite

@zacpwhite

This comment has been minimized.

Copy link
Contributor Author

zacpwhite commented Feb 11, 2019

No problem, although I was in the process of cleaning up even more formatting issues as a result of this removal. I'll submit another PR in the future to clean the rest of these up!

@RussKie

This comment has been minimized.

Copy link

RussKie commented Feb 13, 2019

Please use GH special keywords like "Fixes" or "Closes" to have the underlying issue automatically closed upon merge.
#321 should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment