New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ` /// <include file='` an `///<internalonly/>` comments #426

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@reaction1989
Copy link
Contributor

reaction1989 commented Feb 10, 2019

fixes #167

following RegExes were used:

^.///.$\n
^./// <include file='.$\n

Had to do datagridview manually because of the comments

@reaction1989 reaction1989 requested a review from dotnet/dotnet-winforms as a code owner Feb 10, 2019

reaction1989 and others added some commits Feb 10, 2019

Update dependencies from dotnet/corefx (#424)
* Update dependencies from https://github.com/dotnet/corefx build 20190209.6

This change updates the following dependencies
- System.CodeDom - 4.6.0-preview.19109.6
- Microsoft.Win32.SystemEvents - 4.6.0-preview.19109.6
- Microsoft.Win32.Registry - 4.6.0-preview.19109.6
- System.Windows.Extensions - 4.6.0-preview.19109.6
- System.Configuration.ConfigurationManager - 4.6.0-preview.19109.6
- System.Security.Cryptography.Cng - 4.6.0-preview.19109.6
- System.Security.Permissions - 4.6.0-preview.19109.6
- System.Drawing.Common - 4.6.0-preview.19109.6

* Update dependencies from https://github.com/dotnet/corefx build 20190210.4

This change updates the following dependencies
- System.CodeDom - 4.6.0-preview.19110.4
- Microsoft.Win32.SystemEvents - 4.6.0-preview.19110.4
- Microsoft.Win32.Registry - 4.6.0-preview.19110.4
- System.Windows.Extensions - 4.6.0-preview.19110.4
- System.Configuration.ConfigurationManager - 4.6.0-preview.19110.4
- System.Security.Cryptography.Cng - 4.6.0-preview.19110.4
- System.Security.Permissions - 4.6.0-preview.19110.4
- System.Drawing.Common - 4.6.0-preview.19110.4
@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Feb 11, 2019

Looks like PropertyGrid.cs got messed up

manuelvalenzuela and others added some commits Feb 11, 2019

Fixed broken link pointing to contributing.md (#413)
* Fixed broken link pointing to contributing.md

* roadmap.md link dependent on the branch
Removed ResourceExposure/ResourceConsumption attributes (#419)
* Removed Obsolete ResourceExposure / ResourceConsumption attributes

* Remove empty lines
Remove dead ctor checks in ListItemConverter (#367)
* Remove dead code from list converters

* Code cleanup for list converters
@@ -18,22 +18,17 @@ internal class CommonUnsafeNativeMethods
internal const int LOAD_LIBRARY_SEARCH_SYSTEM32 = 0x00000800;

[DllImport(ExternDll.Kernel32, SetLastError = true, ExactSpelling = true, CharSet = CharSet.Ansi)]
[ResourceExposure(ResourceScope.Process)]

This comment has been minimized.

@RussKie

RussKie Feb 13, 2019

Why has this changed? This change relates to #321.
Please rebase on top of the latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment