Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GridItem[Collection] tests and cleanup code #566

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@hughbe
Copy link
Contributor

hughbe commented Mar 10, 2019

No description provided.

@hughbe hughbe requested a review from dotnet/dotnet-winforms as a code owner Mar 10, 2019

@hughbe hughbe changed the title Grid tests Add GridItem[Collection] tests and cleanup code Mar 10, 2019

@@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework>
<LangVersion>7.3</LangVersion>

This comment has been minimized.

@hughbe

hughbe Mar 10, 2019

Author Contributor

Required to make GridItemCollection._entries private protected instead of internal, which actually matches what the access modified of this field should be

@hughbe hughbe force-pushed the hughbe:grid-tests branch from 13a2e80 to f113e66 Mar 10, 2019

hughbe added some commits Mar 10, 2019

Fix build
This type is now sealed

@JuditRose JuditRose merged commit e1341a5 into dotnet:master Mar 13, 2019

1 check passed

license/cla All CLA requirements met.
Details

@hughbe hughbe deleted the hughbe:grid-tests branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.