Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix: use a project instead of template #569

Merged
merged 13 commits into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@zsd4yr
Copy link
Member

zsd4yr commented Mar 11, 2019

because dotnetcli version needs to be the same

@zsd4yr zsd4yr requested a review from dotnet/dotnet-winforms as a code owner Mar 11, 2019

@zsd4yr zsd4yr changed the title make project helix: use a project instead of template Mar 11, 2019

@zsd4yr

This comment has been minimized.

Copy link
Member Author

zsd4yr commented Mar 12, 2019

@zsd4yr zsd4yr merged commit 671d130 into master Mar 12, 2019

1 check passed

license/cla All CLA requirements met.
Details

@zsd4yr zsd4yr deleted the dev/zadanz/helix-project branch Mar 12, 2019

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Mar 15, 2019

@zsd4yr are you aware that this is rebuilding the product binaries during the test leg? As a result you aren’t testing the bits you actually publish.

@zsd4yr

This comment has been minimized.

Copy link
Member Author

zsd4yr commented Mar 15, 2019

@zsd4yr are you aware that this is rebuilding the product binaries during the test leg? As a result you aren’t testing the bits you actually publish.

Discussing offline in case anyone comes by and is wondering what is up here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.