Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the ArrayEditor from the classic framework and add unit test. #575

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@KlausLoeffelmann
Copy link
Member

KlausLoeffelmann commented Mar 12, 2019

The ArrayEditor is needed to enable runtime designer functionality for the Chart control (WinForms Core DataVisualization).

Klaus Löffelmann
Port the ArrayEditor from the classic framework and add unit test.
The ArrayEditor is needed to enable runtime designer functionality for the Chart control (WinForms Core DataVisualization).

@KlausLoeffelmann KlausLoeffelmann requested a review from dotnet/dotnet-winforms as a code owner Mar 12, 2019

Assert.True(underTest.CanRemove(1234));
Assert.Equal("net.ComponentModel.CollectionEditor", underTest.GetHelpTopic());
Assert.Equal("my string", underTest.GetItemDisplayText("my string"));
}

This comment has been minimized.

@JuditRose

JuditRose Mar 12, 2019

Member

Maybe here I would add a few more asserts to test the overridden SetItems, GetItems, CreateCollectionItemType methods in ArrayEditor.

@JuditRose
Copy link
Member

JuditRose left a comment

Besides my minor comment, LGTM.

@dreddy-work dreddy-work self-requested a review Mar 12, 2019

@dreddy-work

This comment has been minimized.

Copy link
Member

dreddy-work commented Mar 12, 2019

Please make sure facads are upto date with this change.

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Mar 12, 2019

would just like to see proof of the facades / dll type forwarding 😄

@zsd4yr

This comment has been minimized.

Copy link
Member

zsd4yr commented Mar 12, 2019

checked locally; I'm satisfied
image

@zsd4yr

zsd4yr approved these changes Mar 12, 2019

@zsd4yr zsd4yr merged commit a719802 into master Mar 12, 2019

@zsd4yr zsd4yr deleted the dev/klloeffe/ArrayEditorForChartControl branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.