Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TypeCodeDomSerializer #757

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
3 participants
@JuditRose
Copy link
Member

JuditRose commented Apr 12, 2019

This component is required by the new .net core designer.
17 files changed, but only one class added with unit tests, the rest is translation resource resx files.

Related issue: #608

@JuditRose JuditRose requested a review from dotnet/dotnet-winforms as a code owner Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #757 into master will decrease coverage by 0.03211%.
The diff coverage is 7.42358%.

@@                Coverage Diff                 @@
##              master       #757         +/-   ##
==================================================
- Coverage   24.54562%   24.5135%   -0.03213%     
==================================================
  Files           1026       1028          +2     
  Lines         284124     284582        +458     
  Branches       38434      38508         +74     
==================================================
+ Hits           69740      69761         +21     
- Misses        210486     210922        +436     
- Partials        3898       3899          +1
Flag Coverage Δ
#Debug 24.5135% <7.42358%> (-0.03212%) ⬇️
#production 16.77334% <2.75229%> (-0.02882%) ⬇️
#test 98.55207% <100%> (+0.00118%) ⬆️
@DustinCampbell
Copy link
Member

DustinCampbell left a comment

LGTM, though you might consider waiting for somebody else's review before merging.

@zsd4yr

zsd4yr approved these changes Apr 15, 2019

Copy link
Member

zsd4yr left a comment

LGTM

@JuditRose JuditRose merged commit cefcf0d into master Apr 15, 2019

1 check passed

license/cla All CLA requirements met.
Details

@zsd4yr zsd4yr deleted the port-TypeCodeDomSerializer branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.