Fix FolderNameEditor memory leak on cancel #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughbe
force-pushed
the
foldernameeditor-tests
branch
from
c396653
to
b7a8dd4
Compare
weltkante
suggested changes
Apr 13, 2019
src/System.Windows.Forms.Design.Editors/src/Misc/UnsafeNativeMethods.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design.Editors/src/Misc/UnsafeNativeMethods.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/FolderNameEditor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/FolderNameEditor.cs
Outdated
Show resolved
Hide resolved
|
@JeremyKuhne would you mind taking a look at this one as well? |
|
Reviewing... |
JeremyKuhne
reviewed
Apr 15, 2019
JeremyKuhne
reviewed
Apr 15, 2019
JeremyKuhne
requested changes
Apr 15, 2019
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/FolderNameEditor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/FolderNameEditor.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/FolderBrowserDialog.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/FolderBrowserDialog.cs
Outdated
Show resolved
Hide resolved
JeremyKuhne
reviewed
Apr 15, 2019
src/System.Windows.Forms.Design.Editors/src/System/Windows/Forms/Design/FolderNameEditor.cs
Outdated
Show resolved
Hide resolved
JeremyKuhne
reviewed
Apr 15, 2019
src/System.Windows.Forms/src/System/Windows/Forms/FileDialogCustomPlace.cs
Show resolved
Hide resolved
hughbe
force-pushed
the
foldernameeditor-tests
branch
from
d4f9a2c
to
f65f9f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
===================================================
+ Coverage 26.24093% 26.25141% +0.01048%
===================================================
Files 1054 1057 +3
Lines 287909 287916 +7
Branches 38463 38461 -2
===================================================
+ Hits 75550 75582 +32
+ Misses 208380 208350 -30
- Partials 3979 3984 +5
|
JeremyKuhne
approved these changes
Apr 16, 2019
| } | ||
| finally | ||
| { | ||
| ArrayPool<char>.Shared.Return(displayName); |
There was a problem hiding this comment.
Just a note for future reference. In scenarios where perf is more critical and you don't expect errors to frequently happen it is ok to not return arrays to the pool (i.e. don't need to introduce a try block).
zsd4yr
approved these changes
Apr 16, 2019
|
Thanks @hughbe and @JeremyKuhne ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #768
Fixes #770
Fixes #767