New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLNS sweep to ensure parity with desktop framework #119

Closed
rladuca opened this Issue Dec 7, 2018 · 17 comments

Comments

Projects
None yet
4 participants
@rladuca
Copy link
Member

rladuca commented Dec 7, 2018

  • .NET Core Version: (e.g. 3.0 Preview1, or daily build number, use dotnet --info) All
  • Windows version: (winver) All
  • Does the bug reproduce also in WPF for .NET Framework 4.8?: No

Problem description:
WPF is missing various xmlns attributes in its reference assemblies. We need to sweep all of them to ensure we pick everything up.
Actual behavior:
N/A
Expected behavior:
N/A
Minimal repro:
See the various related issues.

@rladuca rladuca added the bug label Dec 7, 2018

@rladuca rladuca added this to the 3.0 milestone Dec 7, 2018

@rladuca rladuca self-assigned this Dec 7, 2018

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Dec 11, 2018

We've completed the sweep and we were missing both WindowsBase and System.Xaml reference assembly XMLNS attributes.

I'll update when I am sure the fixes have made the daily builds.

@taori

This comment has been minimized.

Copy link

taori commented Jan 14, 2019

@rladuca just checking - forgot to update, or no updates yet? Currently trying to compile for netcore3.0 and XmlnsDefinitionAttribute + XmlnsPrefix is missing.

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 15, 2019

@taori I want to make sure I understand, are you saying the attributes themselves are missing?

I just created a new .NET Core 3 project and I was able to add XmlnsDefinition and also XmlnsPrefix, they both were under System.Windows.Markup as expected. Cracking open the binaries from the latest nightly, I see them defined there as well.

Is there a reproduction application you can link me to just so I can get a better idea of what is going on?

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 15, 2019

Also this issue should have been closed, I forgot to do so when the daily build had updated.

@taori I'll keep this open in case I missed something, but if it's not the same problem, we might shift to opening a new issue.

@taori

This comment has been minimized.

Copy link

taori commented Jan 15, 2019

@rladuca https://github.com/taori/Amusoft.UI.WPF.git , src/Amusoft.UI.WPF/Amusoft.UI.WPF.csproj did not compile with netcoreapp3.0 - perhaps i am on a different sdk build which is not public yet ofc. If so - is there an alternative download source other than https://dotnet.microsoft.com/download/dotnet-core/3.0, where i can obtain an installer?

Using the latest sdk on the download site provides me with this:

grafik

@taori

This comment has been minimized.

Copy link

taori commented Jan 15, 2019

I figured out why -

my csproj had

<Project Sdk="Microsoft.NET.Sdk">

instead of

<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">

After changing it, it compiled just fine.

@ccifra

This comment has been minimized.

Copy link

ccifra commented Jan 15, 2019

@radiy

This comment has been minimized.

Copy link

radiy commented Jan 15, 2019

Same here x:Reference still missing. Sdk version 3.0.100-preview-010086.

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 15, 2019

@taori That happens, having to consider the implicit references via the SDK is a new thing for a lot of WPF developers. Glad to hear it works.

@radiy and @ccifra, I'll take a look today at x:reference.

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 15, 2019

This is my mistake in my previous change, I didn't add the file to the build correctly. Apologies, this should be fixed in daily builds a few days from now. I believe this fix will also make Preview 2.

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 17, 2019

You should now see this fix in the latest daily build (3.0.0-preview-27315-14) of the WindowsDesktop SDK.

I was able to compile with x:Reference without issue on that build.

@radiy and @ccifra if you can confirm that you're good to go, I'll close this. Thanks!

@radiy

This comment has been minimized.

Copy link

radiy commented Jan 18, 2019

@rladuca Thank you, finally something compiles.

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 18, 2019

This is in both the latest daily builds and will make it into Preview 2, so I am going to close this.

Feel free to comment and ping me if you think there is more to fix.

@rladuca rladuca closed this Jan 18, 2019

@ccifra

This comment has been minimized.

Copy link

ccifra commented Jan 24, 2019

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 24, 2019

@ccifra I installed the latest daily build of .NET Core 3 and was able to compile and run the sample code that you pasted with no issue.

I cracked open both the installed shared framework lib binary and the ref assembly from the corresponding nuget package. Both contain the XML namespace definitions. This was checked in early enough to snap to Preview 2 builds (there is no officially released Preview 2 yet) so it will be out with that as well.

Are you sure you're using the latest daily builds? I can't see what you posted as the error condition.

@ccifra

This comment has been minimized.

Copy link

ccifra commented Jan 28, 2019

@rladuca

This comment has been minimized.

Copy link
Member Author

rladuca commented Jan 28, 2019

Yep, that can be confused when multiple things with the preview moniker are in flight. Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment