Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGridCell.DataGridOwner accessibility #2261

Closed
soeron opened this issue Nov 29, 2019 · 2 comments

Comments

@soeron
Copy link

@soeron soeron commented Nov 29, 2019

Currently the property DataGridOwner is marked as internal, which is coming from full framework like this. But there are many situations where the cell may need access to its owning data grid. A simple example is the VerticalContentAlignment property of the datagrid which does nothing and is not respected in any way with the current templates in the .NET framework which is ported line by line for now. There are many other use cases where accessing the owning data grid is needed. Grid wide attached properties etc.
Other elements of the datagrid like rows, columns have this property and it is still internal. Please make it public. I can't see a reason to leave it internal.

@soeron soeron changed the title DataGridCell.DataGridOwner accessabilty DataGridCell.DataGridOwner accessibility Nov 29, 2019
@arpitmathur

This comment has been minimized.

Copy link
Contributor

@arpitmathur arpitmathur commented Dec 3, 2019

@soeron Thanks for filing the issue. The team discussed this and we are not planning to change the access modifier for this property.

@arpitmathur arpitmathur closed this Dec 3, 2019
@soeron

This comment has been minimized.

Copy link
Author

@soeron soeron commented Dec 4, 2019

@arpitmathur Fair enough. Can you fix then VerticalContentAlignment to do what it is supposed to do for DataGrid control then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.