Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to changes in ApiCompat and re-baseline #2414

Closed
rladuca opened this issue Jan 10, 2020 · 4 comments · Fixed by #2175
Closed

React to changes in ApiCompat and re-baseline #2414

rladuca opened this issue Jan 10, 2020 · 4 comments · Fixed by #2175
Assignees
Milestone

Comments

@rladuca
Copy link
Member

@rladuca rladuca commented Jan 10, 2020

ApiCompat was altered to add support for member level attribute checks (see dotnet/arcade@2fdcfc2#diff-9b7e2af6cbe16f7c69be4a9cc5ae4418)

Due to this change, WPF needs to examine and re-baseline its ApiCompat errors. We should also update to the latest exclusions being used in dotnet/runtime since that will help reduce the set of errors.

This is blocking flow from Arcade in this PR: #2175

This work will be based on the Arcade flow above, but I am using this issue as a record of the reasoning behind various baselines.

@rladuca rladuca self-assigned this Jan 10, 2020
@rladuca rladuca added this to the 5.0 milestone Jan 10, 2020
@rladuca

This comment has been minimized.

Copy link
Member Author

@rladuca rladuca commented Jan 10, 2020

ExcludingSecurityTreatAsSafeAttribute as these are no longer in use.

@rladuca

This comment has been minimized.

Copy link
Member Author

@rladuca rladuca commented Jan 10, 2020

Excluding CommonDependencyPropertyAttribute as this is only used in internal generation of https://github.com/dotnet/wpf/blob/master/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/KnownTypes.cs and is not needed in the reference assembly.

@rladuca

This comment has been minimized.

Copy link
Member Author

@rladuca rladuca commented Jan 10, 2020

Much of the noise here is CannotChangeAttribute errors. These are generally due to conversion from some enumeration in the implementation to the equivalent numerical value in the reference assembly (GenAPI does this). These can all be baselined away (as we've done before) and will significantly reduce noise.

@rladuca

This comment has been minimized.

Copy link
Member Author

@rladuca rladuca commented Jan 10, 2020

MS.Internal.CustomCategoryAttribute
System.Windows.CustomCategoryAttribute
System.ComponentModel.DefaultValueAttribute

Can all be baselined, the designer looks at implementation, not reference assemblies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.