New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF should build against latest CoreFx packages #248

Closed
ericstj opened this Issue Jan 9, 2019 · 12 comments

Comments

Projects
None yet
7 participants
@ericstj
Copy link
Member

ericstj commented Jan 9, 2019

Currently this repository is set up to get its NETCoreApp assemblies as an implicit framework reference from the SDK.

This project does not define a RuntimeFrameworkVersion, so it gets the default implicit framework references.
https://github.com/dotnet/wpf/blob/master/src/Microsoft.DotNet.Wpf/src/System.Xaml/System.Xaml.csproj#L5

And it's picking up the 3.0 dotnet cli + SDK that will have "latest" (that's made its way to the SDK repo).

"dotnet": "3.0.100-preview-009764",

However, its picking up much older versions of packages that build on top of NETCoreApp.

<SystemSecurityVersion>4.5.0</SystemSecurityVersion>
<SystemReflectionEmitVersion>4.3.0</SystemReflectionEmitVersion>

This will "work" in most cases, since we make compatible changes to the surface area, but it has a couple draw backs:

  1. If the packages have implementation assemblies that aren't in the shared framework, your tests in this repo will be running with much older implementation than what gets bundled into the desktop shared framework.
  2. When we move types down you'll get compiler errors. See dotnet/corefx#34447.

These dependencies need to change to be the latest packages published from CoreFx and you should have a subscription set up so that maestro auto updates them.

@rladuca

This comment has been minimized.

Copy link
Member

rladuca commented Jan 9, 2019

@danzil This will have to be updated, as well, in our internal Arcade based repositories.

@rladuca

This comment has been minimized.

Copy link
Member

rladuca commented Jan 9, 2019

@stevenbrix Can you look into this being update for this repo? We'll probably have to work by hand (for now) in internal prototypes.

@rladuca rladuca added this to the 3.0 milestone Jan 9, 2019

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Jan 9, 2019

FWIW the internal dotnet-trusted repo was doing this correctly, as well as WinForms.

@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Jan 9, 2019

@stevenbrix, We should be updating versions.props file with latest preview versions of packages like System.Security. Ideally, we'd setup a DARC subscription for these so that these versions are always updated automatically.

@vatsan-madhavan vatsan-madhavan modified the milestones: 3.0, Preview Jan 9, 2019

@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Jan 9, 2019

Changing milestone to Preview - we should fix this as soon as we can..

@danzil

This comment has been minimized.

Copy link
Member

danzil commented Jan 9, 2019

@stevenbrix, see also typo at https://github.com/dotnet/wpf/blob/master/src/Microsoft.DotNet.Wpf/src/System.Xaml/System.Xaml.csproj#L102
SystemSecurityPermissionsVersion instead of SystemSecurityVersion

@stevenbrix

This comment has been minimized.

Copy link
Member

stevenbrix commented Jan 9, 2019

i'll take a look, thanks!

@stevenbrix

This comment has been minimized.

Copy link
Member

stevenbrix commented Jan 9, 2019

@ericstj is there a darc subscription we can add for these, or do we just need to manually update these to match winforms?

@ericstj

This comment has been minimized.

Copy link
Member

ericstj commented Jan 9, 2019

You should be able to subscribe to corefx /cc @safern

@safern

This comment has been minimized.

Copy link
Member

safern commented Jan 9, 2019

Yes, you need to add a subscription to corefx directly in darc. Please reach offline if you need any help doing that, but corefx is now publishing everything into BAR, so once you have the subscription correctly, you should be able to run darc to update you corefx versions.

@AdamYoblick

This comment has been minimized.

Copy link
Member

AdamYoblick commented Jan 9, 2019

@ericstj The process for updating the corefx packages in winforms is still very much manual because I don't think corefx was publishing using darc in the past. We could use some guidance on how to automate this using darc.

Do they have artifacts we can consume now in our version.details.xml ?

@AdamYoblick

This comment has been minimized.

Copy link
Member

AdamYoblick commented Jan 9, 2019

Ahh nevermind, I didn't see Santiago's comments. I will set up the subscriptions in winforms as well.

stevenbrix added a commit that referenced this issue Jan 14, 2019

Merge pull request #254 from dotnet/dev/stevenbrix/buildAgainstCoreFx
build against latest core fx packages

Closes #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment