New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NET.Sdk.WindowsDesktop.props references System.Windows.Controls.Ribbon on .NET 4.0 #255

Open
ericstj opened this Issue Jan 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ericstj
Copy link
Member

ericstj commented Jan 11, 2019

Problem description:
When targeting net40 from a WPF app the build emits a warning.

Actual behavior:
Warning:

C:\Program Files\dotnet\sdk\3.0.100-preview-010046\Microsoft.Common.CurrentVersion.targets(2114,5): warning MSB3267: The primary reference "System.Windows.Controls.Ribbon", which is a framework assembly, could not be resolved in the currently targeted framework. ".NETFramework,Version=v4.0". To resolve this problem, either remove the reference "System.Windows.Controls.Ribbon" or retarget your application to a framework version which contains "System.Windows.Controls.Ribbon".

Expected behavior:
No warning

Minimal repro:
dotnet new wpf
change targetframework to net40 or make it cross-target.
dotnet build

(project also attached)
net40.zip

I believe the fix is here is to put a condition on the _SDKImplicitReference items defined in Microsoft.NET.Sdk.WindowsDesktop.props.

Originally reported here: dotnet/core#2085 (comment)

@virzak

This comment has been minimized.

Copy link

virzak commented Jan 13, 2019

Same issue with net35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment