New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script fails building with Visual Studio 2019 Preview 1 because script is looking for MsBuild in the wrong place #80

Closed
Wintermute21 opened this Issue Dec 5, 2018 · 15 comments

Comments

Projects
None yet
4 participants
@Wintermute21

Wintermute21 commented Dec 5, 2018

  • .NET Core Version: (3.0 Preview1)
  • Windows version: (Windows 10 build 18290.1000)
  • Does the bug reproduce also in WPF for .NET Framework 4.8?: No

Problem description:
When cloning and building using Visual Studio 2019 Preview 1, build.cmd fails by not looking for NuGet.exe in the correct directory for Preview.
Line 183 of eng/common/tools.ps1 has $script:buildDriver = Join-Path $vsInstallDir "MSBuild\15.0\Bin\msbuild.exe" where for Preview1 it should be $script:buildDriver = Join-Path $vsInstallDir "MSBuild\Current\Bin\msbuild.exe"
Actual behavior:
build fails with NuGet.exe not found
Expected behavior:
build succeeds and restores packages correctly.
Minimal repro:
clone and build under 2019 Preview 1.

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

I should note also that this issue does not occur with the WinForms repo. That build script appears to handle both situations (e.g dealing with 2017 and 2019 paths) correctly.

@vatsan-madhavan

This comment has been minimized.

Member

vatsan-madhavan commented Dec 5, 2018

@chcosta - would this be something that Arcade SDK would need to fix?

This is related to Microsoft/msbuild#3778

Cc @ericstj

@vatsan-madhavan vatsan-madhavan added this to the Preview milestone Dec 5, 2018

@vatsan-madhavan vatsan-madhavan added the bug label Dec 5, 2018

@karelz

This comment has been minimized.

Member

karelz commented Dec 5, 2018

Looks like WPF repo does not have this Arcade change: dotnet/arcade#1409

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

@karelz DARC PRs were failing the CI build as we transitioned to open. The next PR should pick up all related changes and pass the new CI build, giving us the appropriate changes.
See #44 .

@karelz

This comment has been minimized.

Member

karelz commented Dec 5, 2018

Cool, so all we need to do is wait a bit 😆

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

potentially dumb question, but since I manually changed the script to fix it, should I revert that or just do a git pull and it will overwrite what I changed with the fix?

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

@Wintermute21 If you've done work on top of a commit with your fix, you can interactively rebase on top of the latest update once it arrives and just delete that commit.

Otherwise, just be sure you don't commit your fix. Then you can pull the latest update when it arrives and resolve the conflict to pick up the latest.

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

@rladuca Yeah, I hadn't committed my change so I'll just let Git overwrite it.
Thanks.
Btw, this is my first issue in an official MS repo and I appreciate how responsive people have been, especially so late at night. <3

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

@Wintermute21 It's my first official MS repo that I'm directly involved with, excitement all around!

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

it's an amazing time to be a .NET dev and it keeps getting better.

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

#83 failed. I'll start to look at it when I get in this morning. @vatsan-madhavan FYI. We have to figure out what is going on with the latest DARC PRs.

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

#83 now passes after some changes from @vatsan-madhavan . @Wintermute21 Can you retry your build without your workaround and confirm you're good to go?

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

Sure, let me get latest and give it a shot. One sec.

@Wintermute21

This comment has been minimized.

Wintermute21 commented Dec 5, 2018

@rladuca I just did a git pull and it does work out of the box now with the latest changes. 👍

@rladuca

This comment has been minimized.

Member

rladuca commented Dec 5, 2018

@Wintermute21 Closing as everything seems to work now.

@rladuca rladuca closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment