Fixing window theme changes when system's theme is changed #10120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
harshit7962
approved these changes
Nov 29, 2024
Member
harshit7962
left a comment
harshit7962
left a comment
There was a problem hiding this comment.
Verified that the failing case is fixed. Also, skimmed through the performance aspect of the change. Seems like the practical use cases shouldn't have too much of a hit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the Application ThemeMode to Light/Dark and changing the system's theme would not reflect on the window when the window is set to System ThemeMode.
Regression
Yes
Testing
Local build pass. Tested with Sample applications
Risk
Microsoft Reviewers: Open in CodeFlow