Matching the list of color resource keys in Light, Dark and HC files for Fluent #10132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
Kuldeep-MS and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
harshit7962
approved these changes
Nov 29, 2024
Member
harshit7962
left a comment
harshit7962
left a comment
There was a problem hiding this comment.
Plain addition of keys. LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now there is a mismatch between the number of keys in Fluent color ResourceDictionary files ( Light.xaml, Dark.xaml and HC.xaml ). If someone uses one of those resources as a StaticResource in their applications, the applications will crash on theme change.
Customer Impact
Prevents developers from running into possible crash scenarios.
Regression
No
Testing
Local testing, Automated Unit tests
Risk
Minimal. Resources have been added rather than removed so if anyone is already using the resource, they won't see any crash.
Microsoft Reviewers: Open in CodeFlow