Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev guide fix #1028

Merged
merged 3 commits into from Jun 22, 2019

Conversation

Projects
None yet
2 participants
@dotMorten
Copy link
Collaborator

commented Jun 20, 2019

PropertyGroup tag wasn't closing and FrameworkReference must be inside an ItemGroup

dotMorten added some commits Jun 20, 2019

@msftbot msftbot bot added the PR label Jun 20, 2019

@stevenbrix

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Can you also add the fixes described here: dotnet/coreclr#25279 (comment)

I think that should fix all the trouble we've been having. I was about to do this myself but you beat me to getting a PR out :)

@dotMorten

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2019

@stevenbrix Sure I can do that, but it sounded like you weren't completely sure that was the issue?

@stevenbrix

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Oh no, that's definitely the fix. I'm not sure if something changed that caused the old method to no longer work, but the issue was that the local assemblies weren't being added to the deps.json. I looked into some binlogs and figured out which target was responsible for writing them and it makes sense why it doesn't work now, just not why it did before :)

@dotMorten

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2019

Should we add a comment that you need preview 7? I cannot get this working on preview 6 due to the security access thing.

I wrote up a little blog on how to build yourself here: https://xaml.dev/post/2019/06/21/Compiling-and-debugging-WPF

@dotMorten

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 21, 2019

One more thing I'm finding: PresentationCore.dll is not copied over (or it's overwritten by the installed version), so I had to add this silly post-build step to be able to debug that one:

COPY $(WpfRepoRoot)\artifacts\packaging\Debug\Microsoft.DotNet.Wpf.GitHub\lib\netcoreapp3.0\PresentationCore.dll bin\Debug\netcoreapp3.0\win-x86\
@stevenbrix

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Should we add a comment that you need preview 7? I cannot get this working on preview 6 due to the security access thing.

Yeah, preview 7 is definitely needed. Although I'm not sure a comment about a specific version number is the right approach, unless there was a sure way to keep it up-to-date. The general philosophy should probably be "if something isn't working right, first check the sdk version you have installed and what version of Microsoft.NETCore.App is along with it. Make sure that is in sync, or close enough, to the version specified in eng\Version.props. Generally, these stay fairly compatible throughout the development life-cycle, however that isn't always the case. If you install a new SDK and your problem consists, please file an issue so it can be investigated.

@stevenbrix

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

One more thing I'm finding: PresentationCore.dll is not copied over (or it's overwritten by the installed version), so I had to add this silly post-build step to be able to debug that one:

What is the assembly version of PresentationCore? It sounds like it isn't overriding the one contained in the Microsoft.WindowsDesktop.App you have installed. This should be a fairly simple fix if that is the case, it might be that a certain MSBuild property isn't being set properly. Feel free to file an issue if you don't want to look into it now.

@stevenbrix

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Ok, so I opened up PresentationCore.dll in ILspy and the Assembly Version info looks correct (or at least the same as other WPF assemblies). I'm going to file an issue, since that goes beyond updating this dev-guide. thanks for the updates!

Opened #1061 to track this

@stevenbrix stevenbrix merged commit d527035 into dotnet:master Jun 22, 2019

3 checks passed

WIP Ready for review
Details
dotnet-wpf CI Build #20190620.12 succeeded
Details
license/cla All CLA requirements met.

@dotMorten dotMorten deleted the dotMorten:patch-1 branch Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.