Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Update dependencies from dotnet/winforms #2161

Merged

Conversation

@dotnet-maestro
Copy link
Contributor

dotnet-maestro bot commented Nov 5, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/winforms

  • Build: 20191107.8
  • Date Produced: 11/8/2019 5:14 AM
  • Commit: 922e41002e66fb10d703705d9be700c8b30cd63d
  • Branch: refs/heads/release/3.1
  • Updates:
    • Microsoft.Private.Winforms -> 4.8.1-preview1.19557.8
…91105.6

- Microsoft.Private.Winforms - 4.8.1-preview1.19555.6
@msftbot msftbot bot requested review from vatsan-madhavan and rladuca Nov 5, 2019
@msftbot msftbot bot added the PR label Nov 5, 2019
@msftbot msftbot bot requested a review from SamBent Nov 5, 2019
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 5, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.
Copy link
Member

wtgodbe left a comment

Hold off on merging this until we re-open for GA

dotnet-maestro bot added 2 commits Nov 7, 2019
…91107.6

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.6
…91107.7

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.7
@wtgodbe

This comment has been minimized.

Copy link
Member

wtgodbe commented Nov 8, 2019

Got some failures here from the new Winforms change:

System\Windows\Integration\ElementHost.cs(906,18): error CS1061: 'ElementHost' does not contain a definition for 'ContextMenuChanged' and no accessible extension method 'ContextMenuChanged' accepting a first argument of type 'ElementHost' could be found (are you missing a using directive or an assembly reference?) [F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsFormsIntegration\WindowsFormsIntegration.csproj]

System\Windows\Integration\ElementHost.cs(987,51): error CS1061: 'ElementHost' does not contain a definition for 'ContextMenu' and no accessible extension method 'ContextMenu' accepting a first argument of type 'ElementHost' could be found (are you missing a using directive or an assembly reference?) [F:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\WindowsFormsIntegration\WindowsFormsIntegration.csproj]

@RussKie @vatsan-madhavan who should take a look at these?

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.
@RussKie

This comment has been minimized.

Copy link
Member

RussKie commented Nov 8, 2019

@vatsan-madhavan these failure would be related to dotnet/winforms#2157

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.
Copy link
Member

vatsan-madhavan left a comment

This can't be merged as-is.

…ee5-f260a08f2fa9
@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Nov 8, 2019

Ok to merge once build passes

@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies No un-ignored checks.
  • Standard Merge Policies There are reviews that have requested changes.
@vatsan-madhavan vatsan-madhavan requested a review from wtgodbe Nov 8, 2019
@wtgodbe

This comment has been minimized.

Copy link
Member

wtgodbe commented Nov 8, 2019

@vatsan-madhavan we can merge this since #2168 is already in, but we probably should've waited to merge both until the branches open for GA. I'll hold everything at core-setup once these get past wpf-int.

@wtgodbe
wtgodbe approved these changes Nov 8, 2019
@dotnet-maestro

This comment has been minimized.

Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • Standard Merge Policies There are reviews that have requested changes.
@wtgodbe wtgodbe closed this Nov 8, 2019
@wtgodbe wtgodbe reopened this Nov 8, 2019
@wtgodbe wtgodbe closed this Nov 8, 2019
@wtgodbe wtgodbe reopened this Nov 8, 2019
…91107.8

- Microsoft.Private.Winforms - 4.8.1-preview1.19557.8
@wtgodbe wtgodbe merged commit af68b9c into release/3.1 Nov 8, 2019
8 checks passed
8 checks passed
WIP Ready for review
Details
auto-merge.config.enforce No dynamic merge policies are applicable.
dotnet-wpf CI Build #20191107.9 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x64) Build Windows_NT Build_Debug_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x86) Build Windows_NT Build_Debug_x86 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x64) Build Windows_NT Build_Release_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x86) Build Windows_NT Build_Release_x86 succeeded
Details
license/cla All CLA requirements met.
Details
@wtgodbe wtgodbe deleted the darc-release/3.1-7804d4f1-362f-47e0-9ee5-f260a08f2fa9 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.