New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ThreeValuedBool #237

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@hughbe
Copy link
Contributor

hughbe commented Jan 4, 2019

Fixed #218
/cc @stevenbrix

@@ -41,14 +41,6 @@ internal enum BoolMemberBits
Directive = Default,
AllValid = 0xFFFF << 16
}

// Use this instead of a Nullable<bool> when a single-word read is needed for thread safety

This comment has been minimized.

@ptorr-msft

ptorr-msft Jan 7, 2019

Collaborator

What is the impact on thread safety of deleting this?

This comment has been minimized.

@hughbe

hughbe Jan 7, 2019

Contributor

/cc @mikedn

This comment has been minimized.

@mikedn

mikedn Jan 8, 2019

@ptorr-msft See the comment I left in the issue #218

This comment has been minimized.

@ptorr-msft

ptorr-msft Jan 8, 2019

Collaborator

It seems like the most recent comment implies this is a breaking change... am I reading that right? An explicit "this change is OK" or "this change is not OK" would be very helpful.

This comment has been minimized.

@mikedn

mikedn Jan 8, 2019

Well, I'm not familiar with this code so I can only assume that the comment is not out of date or something and that it is indeed supposed to be thread safe. In that case, yes, this change is not safe to make.

This comment has been minimized.

@ptorr-msft

ptorr-msft Jan 8, 2019

Collaborator

Thank you for the additional clarification.

This comment has been minimized.

@stevenbrix

stevenbrix Jan 8, 2019

Member

@mikedn yeah thanks for the clarification. I agree, this does seem to be a breaking change.

This comment has been minimized.

@hughbe

hughbe Jan 8, 2019

Contributor

Closing :)

@hughbe hughbe closed this Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment