Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure C/C++ .lib builds in dotnet-wpf-int will set DebugInformationFormat=oldStyle #2547

Merged
merged 2 commits into from Feb 11, 2020

Conversation

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Feb 11, 2020

Ensure C/C++ .lib builds in dotnet-wpf-int will set DebugInformationFormat=oldStyle.

dotnet/arcade#4763

@msftbot msftbot bot requested a review from rladuca Feb 11, 2020
@msftbot msftbot bot added the PR label Feb 11, 2020
@msftbot msftbot bot requested a review from SamBent Feb 11, 2020
@msftbot

This comment has been minimized.

Copy link

msftbot bot commented Feb 11, 2020

Hello @vatsan-madhavan!

Because this pull request has the auto_merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 30 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
@vatsan-madhavan vatsan-madhavan merged commit 8d9d116 into dotnet:master Feb 11, 2020
8 checks passed
8 checks passed
WIP Ready for review
Details
auto-merge.config.enforce No dynamic merge policies are applicable.
dotnet-wpf CI Build #20200211.1 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x64) Build Windows_NT Build_Debug_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x86) Build Windows_NT Build_Debug_x86 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x64) Build Windows_NT Build_Release_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x86) Build Windows_NT Build_Release_x86 succeeded
Details
license/cla All CLA requirements met.
Details
@vatsan-madhavan vatsan-madhavan deleted the wpfcontrib:wpfbuild-fixups branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.