Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup dependencies #2562

Merged
merged 2 commits into from Feb 12, 2020
Merged

Fixup dependencies #2562

merged 2 commits into from Feb 12, 2020

Conversation

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented Feb 12, 2020

@vatsan-madhavan vatsan-madhavan added this to the 5.0 milestone Feb 12, 2020
@vatsan-madhavan vatsan-madhavan requested a review from wtgodbe Feb 12, 2020
@vatsan-madhavan vatsan-madhavan self-assigned this Feb 12, 2020
@msftbot msftbot bot requested a review from rladuca Feb 12, 2020
@msftbot msftbot bot added the PR label Feb 12, 2020
@msftbot msftbot bot requested a review from SamBent Feb 12, 2020
Copy link
Member

wtgodbe left a comment

This doesn't update the URI's, but I think Maestro will do that for you on the next update - @mmitche can you confirm?

@vatsan-madhavan

This comment has been minimized.

Copy link
Member Author

vatsan-madhavan commented Feb 12, 2020

This doesn't update the URI's, but I think Maestro will do that for you on the next update - @mmitche can you confirm?

It's worse than that. Look at the two commits in this PR. I updated the Uri's manually to dotnet/runtime, and then updated dependencies. darc changed back dotnet/runtime -> dotnet/corefx etc.

@vatsan-madhavan

This comment has been minimized.

Copy link
Member Author

vatsan-madhavan commented Feb 12, 2020

I think this may be the reason.

WinForms has been semi-frozen to an older version of CoreFx/CoreCLR due to C++ tooling problems in dotnet/wpf. Those versions self-report as having been produced by dotnet/corefx etc, like this:

λ darc get-asset --name Microsoft.NETCore.Platforms --version 5.0.0-alpha1.19512.1 --max-age 600
Looking up assets with name 'Microsoft.NETCore.Platforms' and version '5.0.0-alpha1.19512.1' in the last 600 days
Microsoft.NETCore.Platforms @ 5.0.0-alpha1.19512.1
Repository:    https://github.com/dotnet/corefx
Branch:        master
Commit:        8d21b79b924d29088dbde46d42737a657d466b5e
Build Number:  20191012.1
Date Produced: 10/12/2019 6:32 AM
Build Link:    https://dev.azure.com/dnceng/internal/_build/results?buildId=386333
BAR Build Id:  31220
Released:      False
Channels:
- .NET Core 5 Dev
Locations:
- https://dev.azure.com/dnceng/internal/_apis/build/builds/386333/artifacts (Container)
- https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json (NugetFeed)
- https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json (NugetFeed)

I would image that as we move over to newer versions, the repo Uri would get updated... right @mmitche ?

@vatsan-madhavan vatsan-madhavan merged commit f85104f into dotnet:master Feb 12, 2020
8 checks passed
8 checks passed
WIP Ready for review
Details
auto-merge.config.enforce No dynamic merge policies are applicable.
dotnet-wpf CI Build #20200212.5 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x64) Build Windows_NT Build_Debug_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Debug_x86) Build Windows_NT Build_Debug_x86 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x64) Build Windows_NT Build_Release_x64 succeeded
Details
dotnet-wpf CI (Build Windows_NT Build_Release_x86) Build Windows_NT Build_Release_x86 succeeded
Details
license/cla All CLA requirements met.
Details
@vatsan-madhavan vatsan-madhavan deleted the wpfcontrib:fixup-deps branch Feb 12, 2020
@wtgodbe

This comment has been minimized.

Copy link
Member

wtgodbe commented Feb 12, 2020

I would image that as we move over to newer versions, the repo Uri would get updated

That's right - This repo (intentionally) has the same version of Microsoft.Netcore.App.Internal as winforms, which is out of date. Once winforms gets up-to-date, so will this repo. You'll also need to fixup Winforms in the same way you fixed up this repo - Winforms still has CoreFx/CoreClr dependencies which list Microsoft.Netcore.App.Internal as a coherentParentDependency: https://github.com/dotnet/winforms/blob/e32620ed185e3c15fa67bdb7fe93757a735d6edb/eng/Version.Details.xml#L13-L15

@mmitche

This comment has been minimized.

Copy link
Member

mmitche commented Feb 13, 2020

This doesn't update the URI's, but I think Maestro will do that for you on the next update - @mmitche can you confirm?

It's worse than that. Look at the two commits in this PR. I updated the Uri's manually to dotnet/runtime, and then updated dependencies. darc changed back dotnet/runtime -> dotnet/corefx etc.

It will. The isssue with update-dependencies is that there's no easy way to look up the latest of a giving asset on a channel without a source Uri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.