Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme to create DocumentGridPage borders #2574

Open
wants to merge 12 commits into
base: master
from

Conversation

@wjk
Copy link
Contributor

wjk commented Feb 13, 2020

Does what the title says. The border/shadow can now be customized by creating a style with the key {ComponentResourceKey TypeInTargetAssembly={x:Type FrameworkElement}, ResourceId=DocumentGridPageContainerWithBorder} at whatever scope you desire. The default value for this style is a copy of the current, manually constructed border. Here is a zipped demo project; note that you'll have to change the WpfRepoRoot variable in DocumentViewerTest.csproj before building.

I also took the opportunity to rewrite ThemeGenerator.nativeproj. It is now stripped of all MS-internal-isms and can be run with MSBuild directly to regenerate the XAML files in the theme projects.

Fixes #1518.

@msftbot msftbot bot requested review from vatsan-madhavan and rladuca Feb 13, 2020
@msftbot msftbot bot added the PR label Feb 13, 2020
@msftbot msftbot bot requested a review from SamBent Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.