From 1a55d1387cb4a3b18f2576adddd655930bde32ea Mon Sep 17 00:00:00 2001 From: Ryland <41491307+ryalanms@users.noreply.github.com> Date: Wed, 20 Jan 2021 22:40:12 -0800 Subject: [PATCH 1/4] WPF support for ARM64: WPF ARM64 public repo Packaging updates Co-authored-by: Alexandre Zollinger Chohfi Co-authored-by: Marcpems Co-authored-by: Juan Sebastian Hoyos Ayala Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com> --- .../Microsoft.DotNet.Arcade.Wpf.Sdk.ArchNeutral.csproj | 10 +++++----- .../Microsoft.DotNet.Wpf.GitHub.ArchNeutral.csproj | 4 ++-- .../Microsoft.DotNet.Wpf.GitHub.csproj | 2 +- ...soft.DotNet.Wpf.ProjectTemplates.ArchNeutral.csproj | 8 ++++---- ...Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/packaging/Microsoft.DotNet.Arcade.Wpf.Sdk/Microsoft.DotNet.Arcade.Wpf.Sdk.ArchNeutral.csproj b/packaging/Microsoft.DotNet.Arcade.Wpf.Sdk/Microsoft.DotNet.Arcade.Wpf.Sdk.ArchNeutral.csproj index 61dcb4688a6..4055fcfd3db 100644 --- a/packaging/Microsoft.DotNet.Arcade.Wpf.Sdk/Microsoft.DotNet.Arcade.Wpf.Sdk.ArchNeutral.csproj +++ b/packaging/Microsoft.DotNet.Arcade.Wpf.Sdk/Microsoft.DotNet.Arcade.Wpf.Sdk.ArchNeutral.csproj @@ -2,20 +2,20 @@ {B73BB4AB-68DE-4B91-BBB0-AB4F2D504AC3} net5.0 - AnyCPU;x64 + AnyCPU;x64;arm64 $(NoWarn);NU5111 - true - + $(MSBuildProjectName.Replace('.ArchNeutral',''))$(TransportPackageNameSuffix) $(PackageName) @@ -32,13 +32,13 @@ - - + diff --git a/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.ArchNeutral.csproj b/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.ArchNeutral.csproj index 5af1f2df7f5..09fe6a9509c 100644 --- a/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.ArchNeutral.csproj +++ b/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.ArchNeutral.csproj @@ -2,9 +2,9 @@ 9a7e395b-e859-40e2-809d-efb72cf3a2ee net5.0 - AnyCPU;x64 + AnyCPU;x64;arm64 - + $(MSBuildProjectName.Replace('.ArchNeutral',''))$(TransportPackageNameSuffix) $(PackageName) diff --git a/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.csproj b/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.csproj index 05bec6eafd6..b141ceb049c 100644 --- a/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.csproj +++ b/packaging/Microsoft.DotNet.Wpf.GitHub/Microsoft.DotNet.Wpf.GitHub.csproj @@ -2,7 +2,7 @@ c847934a-828c-4ebb-a004-b0e97c8313f4 net5.0 - AnyCPU;x64 + AnyCPU;x64;arm64 diff --git a/packaging/Microsoft.Dotnet.Wpf.ProjectTemplates/Microsoft.DotNet.Wpf.ProjectTemplates.ArchNeutral.csproj b/packaging/Microsoft.Dotnet.Wpf.ProjectTemplates/Microsoft.DotNet.Wpf.ProjectTemplates.ArchNeutral.csproj index 743b67c04c6..66db36f5ea5 100644 --- a/packaging/Microsoft.Dotnet.Wpf.ProjectTemplates/Microsoft.DotNet.Wpf.ProjectTemplates.ArchNeutral.csproj +++ b/packaging/Microsoft.Dotnet.Wpf.ProjectTemplates/Microsoft.DotNet.Wpf.ProjectTemplates.ArchNeutral.csproj @@ -2,18 +2,18 @@ {BFF6C118-3369-43B5-ACA6-D65ED00EEBE0} net5.0 - AnyCPU;x64 + AnyCPU;x64;arm64 - true - + $(MSBuildProjectName.Replace('.ArchNeutral',''))$(TransportPackageNameSuffix) $(PackageName) @@ -21,7 +21,7 @@ - + diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj index 12a2c2898c1..ea204d019b2 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj @@ -2,18 +2,18 @@ {440d06b8-e3de-4c0d-ad25-cd4f43d836e1} net5.0 - AnyCPU;x64 + AnyCPU;x64;arm64 - true - + $(MSBuildProjectName.Replace('.ArchNeutral',''))$(TransportPackageNameSuffix) $(PackageName) From 3202993f489bff5ec82b9e56e7d612603b6606b7 Mon Sep 17 00:00:00 2001 From: Ryland <41491307+ryalanms@users.noreply.github.com> Date: Wed, 20 Jan 2021 23:03:34 -0800 Subject: [PATCH 2/4] Enable arm64 builds on public WPF repo Co-authored-by: Alexandre Zollinger Chohfi Co-authored-by: Marcpems Co-authored-by: Juan Sebastian Hoyos Ayala Co-authored-by: Ryland <41491307+ryalanms@users.noreply.github.com> --- Directory.Build.props | 1 + NuGet.config | 1 - eng/copy-wpf.ps1 | 19 +++++++++---------- eng/helixpublish.proj | 8 ++++---- eng/pipeline.yml | 9 +++++++++ 5 files changed, 23 insertions(+), 15 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 5b7c2447a9c..fd10c974673 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,6 +1,7 @@ wpf + true diff --git a/NuGet.config b/NuGet.config index 5af5f5b2ea0..a1109d88ffa 100644 --- a/NuGet.config +++ b/NuGet.config @@ -9,7 +9,6 @@ - diff --git a/eng/copy-wpf.ps1 b/eng/copy-wpf.ps1 index 11d01eb6fca..cf1c40d7d50 100644 --- a/eng/copy-wpf.ps1 +++ b/eng/copy-wpf.ps1 @@ -37,10 +37,10 @@ Write-Host "Target architecture - configuration: " $arch $Config function CopyBinariesToLocation($location) { $locallyBuiltBinaryLocationBase = Join-Path $RepoRoot "artifacts\packaging" - + Write-Host "Copy native binaries..." - CopyNativeBinariesToLocation $location $locallyBuiltBinaryLocationBase - + CopyNativeBinariesToLocation $location $locallyBuiltBinaryLocationBase + Write-Host "Copy managed binaries..." CopyManagedBinariesToLocation $location $locallyBuiltBinaryLocationBase } @@ -58,7 +58,7 @@ function CopyNativeBinariesToLocation($location, $localBinLocation) } function CopyManagedBinariesToLocation($location, $localBinLocation) { - # Layout of where the managed binaries looks something like this: + # Layout of where the managed binaries looks something like this: # x86 - artifacts\packaging\Debug\Microsoft.DotNet.Wpf.GitHub\lib\net5.0 # x64 - artifacts\packaging\Debug\x64\Microsoft.DotNet.Wpf.GitHub\lib\net5.0 @@ -121,11 +121,11 @@ elseif($testhost) } else { - $location = Resolve-Path (Join-Path $destination "shared\Microsoft.WindowsDesktop.App\$version") + $location = Resolve-Path (Join-Path $destination "shared\Microsoft.WindowsDesktop.App\$version") } Write-Host "Copying binaries to dotnet installation at $location" - + if(![System.IO.Directory]::Exists($location)) { Write-Host "Location unavailable: " $location -ForegroundColor Red @@ -146,7 +146,7 @@ elseif($testhost) Write-Host "** Setting $dotnetVariableToSet to $destination **" Set-Item -Path $dotnetVariableToSet -Value $destination - Write-Host "** Setting env:DOTNET_MULTILEVEL_LOOKUP to 0 **" + Write-Host "** Setting env:DOTNET_MULTILEVEL_LOOKUP to 0 **" $env:DOTNET_MULTILEVEL_LOOKUP=0 } } @@ -159,9 +159,8 @@ else Write-Host "App publishing directory unavailable: " $location -ForegroundColor Red return } - + Write-Host "App publishing directory: " $location Write-Host "Copying binaries to app publishing directory..." - CopyBinariesToLocation $location + CopyBinariesToLocation $location } - diff --git a/eng/helixpublish.proj b/eng/helixpublish.proj index 9fc63bbb47a..0b5ec2397ab 100644 --- a/eng/helixpublish.proj +++ b/eng/helixpublish.proj @@ -7,7 +7,7 @@ + Condition="'$(WpfRuntimeIdentifier)'=='win-x64' or '$(WpfRuntimeIdentifier)'=='win-arm64'"/>