Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOC CHECKIN: Strings not intended to be translated should not be included in System.Xaml satellite assemblies #423

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@ryalanms
Copy link
Member

ryalanms commented Mar 8, 2019

Untranslated strings should not be included in System.Xaml satellite assemblies. Remove strings from shared Strings.resx, add strings to XamlPullParser, and update XLF files for all languages.

@ryalanms ryalanms self-assigned this Mar 8, 2019

@ryalanms ryalanms requested review from stevenbrix and vatsan-madhavan Mar 8, 2019

@vatsan-madhavan

This comment has been minimized.

Copy link
Member

vatsan-madhavan commented Mar 8, 2019

What do you mean by "untranslated strings" ? Do you mean "strings that happened to be untranslated because we couldn't find sufficient localization assitance to do the translation", or do you mean "strings that were never intended to be translated, and therefore should never have appeared in any of the resx files (and should be moved to code-behind as const strings" ?

@ryalanms ryalanms changed the title LOC CHECKIN: Untranslated strings should not be included in System.Xaml satellite assemblies LOC CHECKIN: Strings not intended to be translated should not be included in System.Xaml satellite assemblies Mar 8, 2019

@vatsan-madhavan vatsan-madhavan merged commit c7e7b93 into dotnet:master Mar 8, 2019

1 check passed

license/cla All CLA requirements met.
Details
@ryalanms

This comment has been minimized.

Copy link
Member Author

ryalanms commented Mar 8, 2019

Updated title to more accurately reflect the intent of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.