diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.props b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.props index d9f409bd77b..697cd52fe21 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.props +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.props @@ -6,7 +6,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and created a backup copy. Incorrect changes to this file will make it impossible to load or build your projects from the command-line or the IDE. -Copyright (c) .NET Foundation. All rights reserved. +Copyright (c) .NET Foundation. All rights reserved. *********************************************************************************************** --> @@ -15,10 +15,21 @@ Copyright (c) .NET Foundation. All rights reserved. <_MicrosoftWindowsDesktopSdkImported>true + + + false + + - true diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.targets b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.targets index c594b72551d..285d65252c9 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.targets +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/Sdk/Sdk.targets @@ -6,7 +6,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and created a backup copy. Incorrect changes to this file will make it impossible to load or build your projects from the command-line or the IDE. -Copyright (c) .NET Foundation. All rights reserved. +Copyright (c) .NET Foundation. All rights reserved. *********************************************************************************************** --> @@ -14,4 +14,5 @@ Copyright (c) .NET Foundation. All rights reserved. + diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props index 98b2c24e13e..4fc676239b4 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props @@ -1,4 +1,5 @@ + @@ -19,9 +20,9 @@ - - - <_WpfCommonNetFxReference Include="WindowsBase" /> + <_WpfCommonNetFxReference Include="WindowsBase" /> <_WpfCommonNetFxReference Include="PresentationCore" /> <_WpfCommonNetFxReference Include="PresentationFramework" /> @@ -93,39 +92,38 @@ - + <_SDKImplicitReference Include="@(_WpfCommonNetFxReference)" Condition="'$(UseWPF)' == 'true'"/> - + <_SDKImplicitReference Include="System.Windows.Forms" Condition="('$(UseWindowsForms)' == 'true') " /> - + <_SDKImplicitReference Include="WindowsFormsIntegration" Condition=" ('$(UseWindowsForms)' == 'true') And ('$(UseWPF)' == 'true') "/> - - - - - + Microsoft.NET.Sdk project (and show a suppressible build-time warning). - + + <_UnsupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v1.0" /> @@ -140,17 +138,17 @@ <_UnsupportedNETStandardTargetFramework Include="@(SupportedNETStandardTargetFramework)" /> @@ -159,7 +157,8 @@ - + + diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets index 644d4be4257..edadf38f4b3 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets @@ -1,28 +1,26 @@ - <_MicrosoftNetSdkWindowsDesktop>true + <_MicrosoftNETSdkWindowsDesktop>true true true Wpf - <_WindowsDesktopSdkTargetFrameworkVersionFloor>3.0 - - @@ -30,24 +28,24 @@ - <_TargetFrameworkVersionValue>$([MSBuild]::ValueOrDefault('$(_TargetFrameworkVersionWithoutV)', '$(_UndefinedTargetFrameworkVersion)')) @@ -71,33 +69,28 @@ '$(_TargetFrameworkVersionValue)' >= '$(_WindowsDesktopSdkTargetFrameworkVersionFloor)'">true - - - = '$(_WindowsDesktopSdkTargetFrameworkVersionFloor)')"> - - - - @@ -133,29 +126,33 @@ - + --> - - + --> + + + + diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets b/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets index bfd753c4ea5..cb8fb19ec9a 100644 --- a/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets +++ b/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft.WinFX.targets @@ -19,10 +19,9 @@ true None - + - true - false 1.0.0.0 Installed true .g$(DefaultLanguageSourceExtension) - 5.1.2600.0 @@ -51,32 +47,24 @@ - true true true true - - - - AssignWinFXEmbeddedResource; $(PrepareResourceNamesDependsOn) - - - MarkupCompilePass1; AfterMarkupCompilePass1; @@ -85,38 +73,32 @@ MainResourcesGeneration; $(PrepareResourcesDependsOn) - - - DesignTimeMarkupCompilation; $(CoreCompileDependsOn) - - + - + - - @@ -142,52 +124,42 @@ - - - $(CompileDependsOn); _AfterCompileWinFXInternal - - - <_AfterCompileWinFXInternalDependsOn> PrepareResourcesForSatelliteAssemblies; MergeLocalizationDirectives; AfterCompileWinFX - - - + - - - @@ -326,7 +289,7 @@ XamlDebuggingInformation="$(XamlDebuggingInformation)" GeneratedBaml="" OutputPath="$(IntermediateOutputPath)" - ContinueOnError="false" + ContinueOnError="false" SupportCustomOutputPaths="$(IncludePackageReferencesDuringMarkupCompilation)"> - @@ -349,20 +311,15 @@ TaskParameter="GeneratedBaml" Condition="'$(_RequireMCPass2ForSatelliteAssemblyOnly)' == 'true'" /> - - - - - GenerateTemporaryTargetAssembly; MarkupCompilePass2; @@ -386,12 +341,10 @@ <_CompileTargetNameForLocalType Condition="'$(_CompileTargetNameForLocalType)' == ''">_CompileTemporaryAssembly - - + false <_ResolveProjectReferencesTargetName Condition="'$(IncludePackageReferencesDuringMarkupCompilation)' != 'false'">ResolveProjectReferences <_CompileTemporaryAssemblyDependsOn>BuildOnlySettings;ResolveKeySource;$(_ResolveProjectReferencesTargetName);CoreCompile - @@ -400,22 +353,20 @@ - - - + - + <_ParentProjectName>$([System.IO.Path]::GetFileNameWithoutExtension('$(MSBuildProjectFullPath)')) @@ -425,9 +376,10 @@ - @@ -449,20 +401,20 @@ <_DestGeneratedNuGetPropsAndTargets Include="$(BaseIntermediateOutputPath)project.assets.json"/> <_DestGeneratedNuGetPropsAndTargets Include="$(BaseIntermediateOutputPath)project.nuget.cache"/> - + @@ -471,18 +423,18 @@ <_IntermediateOutputPathNoTargetFrameworkOrRID>$([System.Text.RegularExpressions.Regex]::Replace($(_IntermediateOutputPathNoTargetFrameworkOrRID), "$(RuntimeIdentifier)\\$",, System.Text.RegularExpressions.RegexOptions.IgnoreCase)) - - <_IntermediateOutputPathNoTargetFrameworkOrRID>$([System.Text.RegularExpressions.Regex]::Replace($(_IntermediateOutputPathNoTargetFrameworkOrRID), "$(TargetFramework)\\$",, System.Text.RegularExpressions.RegexOptions.IgnoreCase)) - + - @@ -508,20 +459,18 @@ - - @@ -530,13 +479,10 @@ - - - - - true $(GenerateManifests) - - false - - Internet - - - $(TargetUrl)/$(TargetDeployManifestFileName) $(MSBuildProjectDirectory)\bin\$(Configuration)\$(TargetDeployManifestFileName) -debug "$(StartURL)" $(StartArguments) -DebugSecurityZoneURL "$(DebugSecurityZoneURL)" - @@ -644,14 +578,12 @@ - - - @@ -670,7 +602,6 @@ CertificateThumbprint="$(_DeploymentResolvedManifestCertificateThumbprint)" TimestampUrl="$(ManifestTimestampUrl)" SigningTarget="@(ApplicationManifest)"/> - @@ -688,7 +619,6 @@ CertificateThumbprint="$(_DeploymentResolvedManifestCertificateThumbprint)" TimestampUrl="$(ManifestTimestampUrl)" SigningTarget="@(DeployManifest)"/> - @@ -698,7 +628,6 @@ ================================================================ Classify baml and image files into different groups for Main assembly and satellite assembly respectively. - --> @@ -716,12 +645,10 @@ - - - - - <_ResourceNameInMainAssembly Condition="'$(UICulture)' == ''">$(AssemblyName).g.resources - <_ResourceNameInMainAssembly Condition="'$(UICulture)' != ''">$(AssemblyName).unlocalizable.g.resources - - - - @@ -782,11 +701,10 @@ $(IntermediateOutputPath)$(_ResourceNameInMainAssembly) - - - - - + @@ -915,7 +828,6 @@ Condition="'$(UICulture)' != ''"> - @@ -926,7 +838,6 @@ Condition="'@(NonResxWithCulture)' != ''"> - @@ -937,7 +848,6 @@ - @@ -946,7 +856,6 @@ Condition="'@(Page)' != '' or '@(ApplicationDefinition)' != ''"> - - + - + - + +