Avoid boxing list enumerator in XamlObjectWriter.Logic_ConvertPositionalParamsToArgs #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
dipeshmsft
approved these changes
Apr 1, 2022
dipeshmsft
added
Included in test pass
Queue for test pass
and removed
Queue for test pass
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logic_ConvertPositionalParamsToArgs is using foreach with an
IList<>it gets back fromGetPositionalParameters. Doing so will end up boxing the enumerator, typically of aList<T>, when we can instead just use a for loop with theIList<>, avoiding the boxing and reducing interface calls.Customer Impact
Unnecessary allocation and interface dispatch.
Regression
No
Testing
CI
Risk
Minimal