Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowsBase, PresentationCore, PresentationFramework (+more) sources #720

Merged
merged 4 commits into from May 22, 2019

Conversation

@vatsan-madhavan
Copy link
Member

vatsan-madhavan commented May 22, 2019

This PR adds sources for the following assemblies:

  • WindowsBase
  • PresentationCore
  • PresentationFramework
  • DirectWriteForwarder
  • ReachFramework
  • System.Windows.Input.Manipulations
  • UIAutomation
    • UIAutomationClient
    • UIAutomationClientSideProviders
    • UIAutomationProvider
    • UIAutomationTypes

/cc @dotnet/wpf-developers
/cc @grubioe, @ryalanms , @rladuca, @stevenbrix , @amit-kabra , @fabiant3 , @miguep , @ojhad

@dotMorten

This comment has been minimized.

Copy link
Contributor

dotMorten commented May 22, 2019

WOOHOO! 👏 🎉 🎆 🍻

@ryalanms ryalanms self-requested a review May 22, 2019
@amit-kabra

This comment has been minimized.

Copy link
Contributor

amit-kabra commented May 22, 2019

Yes!

@fabiant3

This comment has been minimized.

Copy link
Member

fabiant3 commented May 22, 2019

Way to go team!!

@rickbrew

This comment has been minimized.

Copy link

rickbrew commented May 22, 2019

Best Pull Request of 2019 Award

https://www.youtube.com/watch?v=DSqNLA1pWxk

@mdtauk

This comment has been minimized.

Copy link

mdtauk commented May 22, 2019

A step closer to being able to do some cool things with WPF control templates when running under WinUI 3.0 maybe. Fluent design for controls to look comfortable alongside UWP XAML.

Fluent.NormalColor.xaml

or

Fluent.Light.xaml

Fluent.Dark.xaml

😄

Copy link
Member

rladuca left a comment

Reviewed the newer targets glue to make everything work with wpf_int. Nothing jumps out, looks good. Proof of the pudding is in the build (and DARC flow). : - )

@matijagrcic

This comment has been minimized.

Copy link

matijagrcic commented May 22, 2019

Amazing!

@vatsan-madhavan vatsan-madhavan merged commit ae17905 into master May 22, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
dotnet-wpf CI Build #20190522.9 succeeded
Details
license/cla All CLA requirements met.
Details
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/big3-oss-prep branch May 22, 2019
@merriemcgaw

This comment has been minimized.

Copy link
Member

merriemcgaw commented May 22, 2019

Awesome guys!! 🥇 🎆 🍾

@lindexi

This comment has been minimized.

Copy link
Contributor

lindexi commented May 23, 2019

Congratulate !!!

@walterlv

This comment has been minimized.

Copy link
Contributor

walterlv commented May 23, 2019

Excellent! WPF is closer and closer to fully open-source.

@h82258652

This comment has been minimized.

Copy link

h82258652 commented May 23, 2019

Great! The best PR in 2019.

@vatsan-madhavan

This comment has been minimized.

Copy link
Member Author

vatsan-madhavan commented May 23, 2019

Folks might have missed this, but there was another set shortly after: #727

@thomasclaudiushuber

This comment has been minimized.

Copy link
Contributor

thomasclaudiushuber commented May 23, 2019

Wow, happened much sooner than I expected it! Congrats to the whole team. Great and important milestone!

@AlexBorsody

This comment has been minimized.

Copy link

AlexBorsody commented May 25, 2019

about time, great job.

@Murgio

This comment has been minimized.

Copy link

Murgio commented May 25, 2019

Love it, this is the single best thing that could possibly happen. 👏 👏

@schungx

This comment has been minimized.

Copy link

schungx commented Jun 13, 2019

Now all we need is some nice gents to port it to Linux... 😆

@weltkante

This comment has been minimized.

Copy link

weltkante commented Jun 13, 2019

@schungx the most important part, the rendering engine, is still missing

@lindexi

This comment has been minimized.

Copy link
Contributor

lindexi commented Jun 13, 2019

@weltkante You are right and the WPF teams say that they do not plan to make WPF cross-platform recently.

@weltkante

This comment has been minimized.

Copy link

weltkante commented Jun 13, 2019

@lindexi other people can still port it, the MIT license should allow it - thats what @schungx was talking about - it's just that Microsoft won't do the work for you, and that they'll probably not include it into the main WPF github/nuget repository - but that doesn't prevent a working implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.