-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding initial Helix support #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
rladuca
reviewed
Jun 1, 2019
Member
|
Just marking NO MERGE until Preview 6 clears. |
1f01c84 to
1bec645
Compare
Contributor
Author
|
I removed the no merge tag since the preview6 branch has snapped. For more detailed information on some of the workarounds, see this comment: |
note: this definitely won't work, it's just some basic initial infrastructure for us to build on once we have a better idea of what to do use dummy HelixWorkItem initially updating pipeline.yml fix Release only condition
this creates the payload as part of msbuild
This is very close, we are just missing native wpf assemblies from being added to the deps.json
QualityVault and STI require the WindowsDesktop package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Enhancement Requested
Product code improvement that does NOT require public API changes/additions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing in Helix
This PR enables running our DRT tests on Helix. I'd recommend seeing the official Helix readme if you are interested in some of the general Helix concepts. I'll briefly outline what we are doing that is a bit unique:
DrtXaml) is responsible for creating this directory (see instances of the MSBuild propertyCreateTestPayload).AfterSolutionBuild.targetsextension point to finish creating the rest of the payload if the-testparameter is passed to the build. Here we add the just built DRTs and if-ciwas not passed into to the build, run the tests.HelixCorrelationPayloaddirectory, where this directory gets deployed to the Helix machine, and is made available in your various helix commands with theHELIX_CORRELATION_PAYLOADenvironment variable. We use the payload directory created described above.HelixWorkItemworking directory.How we are running tests
HelixQueuesthat we selected are Windows.10.Amd64.Open;Windows.7.Amd64.Open;Windows.10.Amd64.ServerRS5.Open. Essentially, this translates to: "Latest Windows 10", "Windows 7", and "Windows 10 RS5 Server" addition. This enables tests to run on some of the most interesting and important SKUs, without overloading the Helix servers and/or making CI runs take an unnecessarily long time to run.Fixes #782