Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no documentation for how to build with alternative framework versions. #2077

Closed
DinoChiesa opened this issue Mar 24, 2023 · 7 comments
Labels
Type: Bug Something isn't working

Comments

@DinoChiesa
Copy link

Summary

The build.cmd script will try to build, currently, with sdk version "8.0.100-preview.1.23115.2".
It will try to download and install that SDK. But what if I don't want to build with a preview of SDK 8.0.100 ?

I have SDK 7.0.104, and I presume yarp builds with the prior SDK. It has done so, in the past.

I would like the README or a separate .md file (BUILDING.md ? ) to describe the options for building. What SDKs are supported? How to modify the global.json file and how to invoke the build.ps1 script to build on other SDKs. An explanation of what is not possible.

Failing that, a blog post, yt video, or a tweet describing how.

To Reproduce

On a machine that does not have SDK 8.0.100-preview.1.23115.2 installed, Run .\build.cmd and you will see a notice that the build script is going to download and install an SDK.

Further technical details

  • current master of reverse-proxy
  • Windows 10
  • .NET SDK 7.0.104
@DinoChiesa DinoChiesa added the Type: Bug Something isn't working label Mar 24, 2023
@DinoChiesa DinoChiesa changed the title There is no documentation for how to build with alternative frameworks. There is no documentation for how to build with alternative framework versions. Mar 24, 2023
@MihaZupan
Copy link
Member

The build script will install the necessary SDK for you. You can also do it manually (the exact version is specified in the global.json).

But what if I don't want to build with a preview of SDK 8.0.100 ?

Why is that?

If you extract just the /src/ReverseProxy folder, that should be buildable standalone with an older SDK.

@Tratcher
Copy link
Member

This project will require the 8.0 SDK once we start working on 8.0 specific features (soon?). Use the SDK provided by build.cmd.

@karelz
Copy link
Member

karelz commented Mar 28, 2023

Triage: For building YARP repo, 8.0 SDK is needed. We are about to add 8.0 TFM - see #2083.
Closing as answered. Let us know if you have more concerns.

@karelz karelz closed this as completed Mar 28, 2023
@DinoChiesa
Copy link
Author

Thanks for the speedy reply. I understand what you wrote.
Maybe I don't understand the intent of YARP.

What if a team wants to standardize on .NET 7.x, and is not ready to move to 8.0? This would not be unusual as .NET 8.0 is still preview. Is there a way to build YARP, or ... am I limited to just using one of the pre-built releases?

@Tratcher
Copy link
Member

YARP consumers should use the nuget package https://www.nuget.org/packages/Yarp.ReverseProxy/2.0.0, that will work with lower SDKs, you don't need to build this repo.

@Tratcher
Copy link
Member

There's also a continuous build package feed if you want newer features, but yes these will be previews:
https://github.com/microsoft/reverse-proxy/blob/main/docs/DailyBuilds.md

@DinoChiesa
Copy link
Author

ok thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants