Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 27, 2024

use search-dialog-icon match search icon

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4968

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Refactor the MeiliSearch component to use the search-dialog-icon for consistency with the search icon.

Bug Fixes:

Chores:

  • Move the MeiliSearch styles to a dedicated SCSS file.

ArgoZhang and others added 6 commits December 27, 2024 16:06
Co-Authored-By: Alex chow <zhouchuanglin@gmail.com>
# Conflicts:
#	src/BootstrapBlazor.Server/wwwroot/css/site.css
Co-Authored-By: Alex chow <zhouchuanglin@gmail.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 27, 2024

Reviewer's Guide by Sourcery

This PR refactors the MeiliSearch component to use the search-dialog-icon class for the search icon, improving consistency and maintainability.

Class diagram showing CSS style changes for search component

classDiagram
    class bb-g-search {
      +display: flex
      +align-items: center
      +color: var(--bb-global-search-color)
      +border: var(--bs-border-width) solid var(--bb-global-search-border-color)
      +width: var(--bb-global-search-width)
      +transition: border-color .3s linear
    }
    note for bb-g-search "Moved from root.scss to meilisearch.scss"

    class search-dialog-icon {
      +cursor: pointer
      +font-size: 18px
    }
    note for search-dialog-icon "New class replacing direct i element styling"

    bb-g-search --> search-dialog-icon: contains
Loading

File-Level Changes

Change Details Files
Moved MeiliSearch styles
  • Created a new SCSS file named meilisearch.scss and moved the MeiliSearch-related styles into it.
  • Imported the meilisearch.scss file into components.scss to include the styles in the build.
  • Removed the MeiliSearch styles from root.scss and site.css.
  • Updated the project file to include the new meilisearch.scss file.
  • Updated the search dialog mask styles in site.css to improve consistency.
src/BootstrapBlazor/wwwroot/scss/root.scss
src/BootstrapBlazor/wwwroot/scss/components.scss
src/BootstrapBlazor/wwwroot/scss/meilisearch.scss
src/BootstrapBlazor.Server/wwwroot/css/site.css
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#4968 Use search-dialog-icon to match search icon styling

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 27, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 27, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) December 27, 2024 12:27
@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ff8d775) to head (66d1141).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4969   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          630       630           
  Lines        28099     28099           
  Branches      4036      4036           
=========================================
  Hits         28099     28099           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit b434bdb into main Dec 27, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-searchbox branch December 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(MeiliSearch): use search-dialog-icon match search icon

2 participants