-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(MeiliSearch): use search-dialog-icon match search icon #4969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Alex chow <zhouchuanglin@gmail.com>
# Conflicts: # src/BootstrapBlazor.Server/wwwroot/css/site.css
Co-Authored-By: Alex chow <zhouchuanglin@gmail.com>
Reviewer's Guide by SourceryThis PR refactors the MeiliSearch component to use the search-dialog-icon class for the search icon, improving consistency and maintainability. Class diagram showing CSS style changes for search componentclassDiagram
class bb-g-search {
+display: flex
+align-items: center
+color: var(--bb-global-search-color)
+border: var(--bs-border-width) solid var(--bb-global-search-border-color)
+width: var(--bb-global-search-width)
+transition: border-color .3s linear
}
note for bb-g-search "Moved from root.scss to meilisearch.scss"
class search-dialog-icon {
+cursor: pointer
+font-size: 18px
}
note for search-dialog-icon "New class replacing direct i element styling"
bb-g-search --> search-dialog-icon: contains
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4969 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28099 28099
Branches 4036 4036
=========================================
Hits 28099 28099 ☔ View full report in Codecov by Sentry. |
use search-dialog-icon match search icon
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4968
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactor the MeiliSearch component to use the search-dialog-icon for consistency with the search icon.
Bug Fixes:
Chores: