-
-
Notifications
You must be signed in to change notification settings - Fork 364
revert(GetJsonStringFromAssembly): merge json from entry assembly #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Diego2098 <82756760+kimdiego2098@users.noreply.github.com>
This reverts commit 42252be.
Reviewer's Guide by SourceryThe pull request merges JSON localization files from the entry assembly into the current assembly. This ensures that the application's main assembly is also checked for localization resources, in addition to the current assembly and any additional assemblies specified in the options. Sequence diagram for JSON localization file merging processsequenceDiagram
participant App as Application
participant LO as LocalizationOptions
participant CA as Current Assembly
participant EA as Entry Assembly
participant AA as Additional Assemblies
App->>LO: GetJsonStringFromAssembly()
LO->>CA: Get resource files
LO->>EA: Get Entry Assembly
alt Entry Assembly != Current Assembly
LO->>EA: Get resource files
end
opt AdditionalJsonAssemblies not null
LO->>AA: Get resource files
end
LO->>LO: Merge all resource streams
LO-->>App: Return configuration sections
Flow diagram for JSON resource resolutiongraph TD
A[Start] --> B[Get Current Assembly Resources]
B --> C{Is Entry Assembly Different?}
C -->|Yes| D[Add Entry Assembly Resources]
C -->|No| E{Additional Assemblies Exist?}
D --> E
E -->|Yes| F[Add Additional Assembly Resources]
E -->|No| G[Merge All Resources]
F --> G
G --> H[Return Configuration]
H --> I[End]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template, particularly the risk assessment and verification sections, to help maintainers better understand the impact of these changes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 643 643
Lines 28901 28906 +5
Branches 4108 4109 +1
=========================================
+ Hits 28901 28906 +5 ☔ View full report in Codecov by Sentry. |
merge json from entry assembly
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5301
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: