Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeId type change of DiscoveryOptions for Consul #314

Closed
visionding opened this issue Apr 12, 2019 · 2 comments

Comments

@visionding
Copy link

commented Apr 12, 2019

存在多个服务或者服务有多个实例的时候,整型的NodeId不容易确保唯一,改成字符串类型后可以根据IP地址+端口号生成

@wu-yafeng

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

GetHashCode may works to you

@yang-xiaodong yang-xiaodong changed the title DiscoveryOptions的NodeId可否改为string类型 NodeId type change of DiscoveryOptions for Consul May 11, 2019

yang-xiaodong added a commit that referenced this issue May 11, 2019
@yang-xiaodong

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Thank you for your report,
We have updated the NodeId to string, which may cause some unknown problems, but I think keeping the data type of Consul will not cause too much trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.