Skip to content

PHP 8.2 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osirismx opened this issue Apr 27, 2023 · 8 comments
Open

PHP 8.2 #185

osirismx opened this issue Apr 27, 2023 · 8 comments

Comments

@osirismx
Copy link

When i actualice to PHP 8.2 and i get a lot of errors, somebody is working on this change?

@derStephan
Copy link

no

@GwynethLlewelyn
Copy link
Contributor

GwynethLlewelyn commented Jul 15, 2023

Not really :) My last effort was to get it working under 8.0...

You're welcome to try it and see if it works under 8.2.

@GwynethLlewelyn
Copy link
Contributor

Slight update: I found out that I'm actually running dotProject under PHP 8.2 after all. I didn't even notice that I have upgraded PHP for it and then completely forgot to check what version it had been upgraded to. Duh! SIlly me :)

Anyway, I'm happy to report that, as far as I could test, my branch of dotProject works as smoothly under PHP8.2 as it did under 8.0. I didn't make any changes, but keep in mind that our projects are very simple and very easy to manage, since they have few tasks and even less people working on them (our company's situation is similar to yours — it sort of peaked around 2010 with 30 or so collaborators, but now we're down to the core team of just three of us). This means that the most obscure errors may fail to appear during a casual browsing of the dotProject installation.

@gklesczewski
Copy link

This is really good news. I will see about creating some automated UI tests so we can validate the system capabilities.
Selenium has a PHP binding so we can write the tests in PHP, or if there is a preference for another language (javascript, kotlin, etc.), I can certainly do that instead.
This way we can run the tests in a container set, and run it against different version of PHP to identify any issues as things move forward.

@GwynethLlewelyn
Copy link
Contributor

Well, good luck :) Note that I didn't do a full test on the whole installation. All I did was to open dotProject, log in, and view the kind of things I used to do on a daily basis (including taking a peek at the Gantt chart!), such as adding a few tasks here and there and updating others. This was not at all thorough; nevertheless, what I experimented with not only worked, but it didn't drop any errors! Not on the logs, at least...

The only issue I didn't check is by how far my own PR has diverged from master... hopefully there is nothing dramatic to implement :(

@fatabek
Copy link

fatabek commented Feb 27, 2024

Thank you very much for your work. Everything is working very well, we think you have worked only for the basic modules that are loaded first. But the "ProjecyDesigner" module is not activated on the first load and it is a very important module. When you activate it, it makes the date change wrong and the "Gantt Chart" in the module does not work.

We think the date change is not working due to a format error. Is it possible to fix this issue? "Gantt Chart" in this module is not very important in our opinion. We think it is not even necessary in this module. We are trying to support the project in the parts we know as much as possible. We are trying to give answers about some bug messages as much as we know. But our programming knowledge is insufficient in this regard.

Thank you very much for your support.

@porter2311
Copy link

Hello i was wondering what version of SQL you used when upgrading php to 8.2 I am trying to get it working but I keep getting alot of sql errors. I think that it has something to do with the version that I am using.

@gklesczewski
Copy link

Hello i was wondering what version of SQL you used when upgrading php to 8.2 I am trying to get it working but I keep getting alot of sql errors. I think that it has something to do with the version that I am using.

@porter2311 - What version of which database are you using? I am using MariaDB 11.0.2 in a container.
Also, what errors are you receiving?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants