New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Project appends visible <br /> tags to every line in the description, every time you save #38

Open
cleary opened this Issue Nov 27, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@cleary

cleary commented Nov 27, 2018

Hi Adam,
I'm seeing this on my test instance

  • v2.1.9
  • php 7.0 - I've cherry picked the commit from #37 (9b64ca3)

Every time I edit a project and hit submit, every line of the Project Description gets a
tag appended - edit it a couple of times and it gets a lot of spacing, very quickly:

screenshot_20181127_114529

screenshot_20181127_114610

@ajdonnison

This comment has been minimized.

Contributor

ajdonnison commented Nov 27, 2018

I've come across something similar in Tickets. Seems that when I put in the fixes for a heap of XSS vulnerabilities, it has created a heap of formatting issues. I'll try and get to this today.

@cleary

This comment has been minimized.

cleary commented Nov 27, 2018

Thanks!

ajdonnison added a commit that referenced this issue Nov 27, 2018

@ajdonnison

This comment has been minimized.

Contributor

ajdonnison commented Nov 27, 2018

Just pushed a fix for this, it would be great if you could verify it works for you and doesn't break anything else.

@cleary

This comment has been minimized.

cleary commented Nov 27, 2018

I ran around and tried a bunch of similar edit fields, they all look fine - thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment