New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character encoding #46

Open
fatabek opened this Issue Jan 8, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@fatabek
Copy link

fatabek commented Jan 8, 2019

If we write "utf-8" in the "locales.php" file in the "en" directory. Gantt chart characters are not show correctly. Becuase jpgraphs "LANGUAGE_CHARSET" comparison is case-insensitive therefore we must be write "UTF-8" in "locales.php" file for show correctly characters in Gantt charts. In devel branch "locale.php" contain small case like "utf-8".

@ajdonnison

This comment has been minimized.

Copy link
Contributor

ajdonnison commented Jan 8, 2019

Case-insensitive means that either utf-8 or UTF-8 will work. Are you using an external jpgraph library or the one provided with dotProject? If external what version? Can you reference the actual code that makes the comparison that you believe requires the uppercase version?

@fatabek

This comment has been minimized.

Copy link

fatabek commented Jan 9, 2019

No, I am not using external jpgraph library. Change #46 and after try again.

with smallcase:

wsmlletter

with uppercase:

wbigletter

@ajdonnison

This comment has been minimized.

Copy link
Contributor

ajdonnison commented Jan 9, 2019

I suspect the problem is not in jpgraph, but in the projectdesigner gantt.php file where it checks if the locale uses utf-8 (lowercase) and if not will do a conversion to utf-8. This suggests that somewhere along the way the input is not actually utf-8. Can you check the character encoding on your database? That can cause these sorts of issues - remember with the database that there are three character encoding points - the connection charset, the database default charset and the table charset. If any of them don't match the database will attempt conversion.

Another possibility is that the conversion is being undone by jpgraph. You might want to grab the last change I pushed and try that with the lowercase utf-8 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment