Skip to content

h1 Wiki headers #1

Open
stefancrain opened this Issue Oct 19, 2012 · 4 comments

3 participants

@stefancrain

Hi all,

We're very interested in using the Modula-gitlab theme in our redmine deployment, and almost everything looks really good.

In our wiki we utilize h1.title tags for all of our page titles and the rendering is a little bit off.

as seen here

We noticed this problem goes away when we change the title of a wiki to h2. title but there are so many pages and sub-pages that this kind of a change is not an option.

@ytjohn
ytjohn commented Jan 22, 2013

applications.css, line 84-96

h1 {
text-align: left;
font-size: 36px;
line-height: 36px;
font-weight: normal;
color: #474D57;
text-shadow: 0 1px 1px white;
font-family: 'Korolev', sans-serif;
margin: 15px 24px;
padding: 0;
width: 400px;
float: left;
}

This is the only tag that has a fixed pixel width. Removing width:400px and float: left; will fix this for the wiki, but may cause issues with other areas. - In testing on my end, I didn't see any ill effects, but my testing is just a cursory overview.

Going down to line 123, I know how to partially fix this.

Change:
.wiki h1 { font-family: helvetica, "microsoft sans serif", arial, sans-serif; }

To:
.wiki h1 { width: 95%; float: none; font-family: helvetica, "microsoft sans serif", arial, sans-serif; }

The only problem with this is that I'm not sure that 95% is the optimal width. I feel this is an inelegant solution and there should be a way in CSS to "negate" the fixed pixel width in the h1 definition.

@ytjohn
ytjohn commented Jan 22, 2013

On second thought, I found a fork already solved this issue, much better than my quick solution. Either utilize this fork or perhaps a merge could occur.

https://github.com/nysenate/nyss-gitlab-redmine-theme/blob/master/stylesheets/application.css#L103

https://github.com/nysenate/nyss-gitlab-redmine-theme

@stefancrain
@doublerebel
Owner

Thanks @stefancrain and @ytjohn, really appreciate your contributions and feedback! I'm happy to merge any stable fixes, just make a pull request whenever ready.

I'm not sure what the theme differences are between 1.4 and 2.x? I designed the theme with and for 1.4.1 stable, so if you're aware of any code that breaks 1.4 we can put that in a separate branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.