Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change handbook link on members homepage to key code orientation link. #763

Merged
merged 1 commit into from Feb 11, 2023

Conversation

sarahwalters
Copy link
Contributor

What github issue is this PR for, if any?

Didn't file an issue.

What does this code do, and why?

Change the handbook link on members homepage to the key code orientation link.

Discussed during the membership committee meeting on 2/1/23. The handbook is very long, and probably what most people need to know is how to get into the DU space. The key code orientation slide deck explains how to get into the DU space more concisely.

How is this code tested?

Locally -- screenshot below.
No unit tests needed because this is just a text change.

Are any database migrations required by this change?

No

Are there any configuration or environment changes needed?

No

Screenshots please :)

Screenshot 2023-02-01 10 04 00 PM

I tried the new "Key code orientation" link to make sure it goes to the right place.

@sarahwalters
Copy link
Contributor Author

Same as #762 -- it looks like the brakeman check is failing because the current Ruby version (2.7.6) is nearing end of life. I'm not sure if the failing check blocks merging this PR or not.

Discussed during the membership committee meeting on 2/1/23. The
handbook is very long, and probably what most people need to know is
how to get into the DU space. The key code orientation slide deck
explains how to get into the DU space more concisely.
@sarahwalters
Copy link
Contributor Author

The failing check was fixed on main -- rebased past that change and these checks are passing now.

@brittag brittag merged commit 6815566 into main Feb 11, 2023
@brittag brittag deleted the sw/space-entry-link branch February 11, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants