Skip to content

Commit

Permalink
Use a better example of aliasing with identifier.
Browse files Browse the repository at this point in the history
Aliasing from table.column to anything with a period is not allowed (at least
not in mysql). Provide a better example that works across databases.

Add a test to TestLiteralAliasedExpression that uses an IdentifierExpression.
  • Loading branch information
Patrick Scott committed Mar 19, 2015
1 parent 12210d5 commit 310eb65
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions dataset_test.go
Expand Up @@ -369,6 +369,10 @@ func (me *datasetTest) TestLiteralAliasedExpression() {
assert.NoError(t, ds.Literal(me.Truncate(buf), Literal("count(*)").As("count")))
assert.Equal(t, buf.args, []interface{}{})
assert.Equal(t, buf.String(), `count(*) AS "count"`)

buf = NewSqlBuilder(false)
assert.NoError(t, ds.Literal(me.Truncate(buf), I("a").As(I("b"))))
assert.Equal(t, buf.String(), `"a" AS "b"`)
}

func (me *datasetTest) TestBooleanExpression() {
Expand Down
4 changes: 2 additions & 2 deletions example_test.go
Expand Up @@ -136,13 +136,13 @@ func ExampleAliasMethods() {
sql, _, _ = db.From("test").Select(goqu.L("sum(amount)").As("total_amount")).ToSql()
fmt.Println(sql)

sql, _, _ = db.From("test").Select(goqu.I("test.a").As(goqu.I("test.b"))).ToSql()
sql, _, _ = db.From("test").Select(goqu.I("a").As(goqu.I("as_a"))).ToSql()
fmt.Println(sql)
// Output:
// SELECT "a" AS "as_a" FROM "test"
// SELECT COUNT(*) AS "count" FROM "test"
// SELECT sum(amount) AS "total_amount" FROM "test"
// SELECT "test"."a" AS "test"."b" FROM "test"
// SELECT "a" AS "as_a" FROM "test"

}

Expand Down

0 comments on commit 310eb65

Please sign in to comment.