Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: InsertDataset.WithDialect return old dataset #126

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@chen56
Copy link
Contributor

commented Aug 11, 2019

bugfix: InsertDataset.WithDialect return old dataset, should be return new dataset

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          47       47           
  Lines        3556     3556           
=======================================
  Hits         3110     3110           
  Misses        386      386           
  Partials       60       60
Impacted Files Coverage Δ
insert_dataset.go 97.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3237124...cf5f782. Read the comment docs.

@doug-martin

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

Thank you for the pr I'm currently out of town and won't be able to get this merged until the weekend. Sorry for the delay.

@doug-martin doug-martin merged commit fa4b383 into doug-martin:master Aug 16, 2019
4 checks passed
4 checks passed
GolangCI No issues found!
Details
codecov/patch 100% of diff hit (target 87.45%)
Details
codecov/project 87.45% (+0%) compared to 3237124
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@doug-martin doug-martin referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.