Fix for issue with windows #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

gabynaiman commented Nov 27, 2011

I change two lines in the Storage class that solve the problem with windows usage in 0.7.7 versión.

Owner

dougal commented Nov 27, 2011

Does this fix the issue for all Windows, including those using an NTFS partition from linux?

Do the tests pass under all these situations?

Contributor

gabynaiman commented Dec 2, 2011

Sorry for the delay. I had a lot of work.
Just tried it on windows. The problem is that cann't rename the temporary
files, so I changed it to use always the real names. Not the best solution,
but without those changes on windows does not work.

If I can help with something let me know.
Thanks.

2011/11/27 Douglas F Shearer <
reply@reply.github.com

Does this fix the issue for all Windows, including those using an NTFS
partition from linux?

Do the tests pass under all these situations?


Reply to this email directly or view it on GitHub:
#21 (comment)

+1 this pull. Tried using acts_as_indexed for first time, and it just didn't work, until I found this pull request.

Owner

dougal commented Feb 28, 2012

I've merged this into the development branch.

You can run this branch with the following in your Gemfile:

gem 'acts_as_indexed', :git => 'git@github.com:dougal/acts_as_indexed.git', :branch => 'development'

Let me know how you get on with it and I'll merge to master and do a new release.

Milhouse commented Mar 2, 2012

working so far in Development on Windows and in staging on my Ubuntu Linux machine, so it seems that it is working okay for me. Thanks.

Owner

dougal commented Mar 14, 2012

Fixed, merged and released in 0.7.8 today.

dougal closed this Mar 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment