Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Oct 26, 2013
  1. @spastorino

    Merge pull request #12655 from rails/ps-remove-surprise-if-in-show-ex…

    spastorino authored
    Remove surprise if from show_exception middleware
  2. @sikachu

    Remove surprise if from show_exception middleware

    sikachu authored
    This increase the readability within the rescue block.
Commits on Oct 25, 2013
  1. @rafaelfranca

    Merge pull request #12648 from chrisledet/patch-1

    rafaelfranca authored
    Fixed typo with after_commit docs
  2. @chrisledet

    Fixed typo with after_commit docs

    chrisledet authored
    Fixed syntax error on `after_commit` docs
  3. @senny

    Merge pull request #12643 from severin/pg_cast_json_on_write

    senny authored
    cast json values on write to be consistent with reading from the db.
  4. @severin
  5. @senny
  6. @senny

    only warn on leaked time zone state instead of rasing an error.

    senny authored
    Raising `RuntimeErrors` skips important cleanup code and leads to
    a lot of subsequent errors. This clutters the test output with a lot
    of noise.
  7. @senny

    Merge pull request #12633 from senny/no_more_time_zone_leaks

    senny authored
    prevent global timezone state from leaking out of test cases.
  8. @senny
  9. @rafaelfranca

    Merge pull request #12642 from ka8725/fix_usage_for_model_generators

    rafaelfranca authored
    Improve usage example for model generator decimal field
  10. @ka8725
  11. @rafaelfranca

    Merge pull request #12641 from jetthoughts/12640_updated_migrations_d…

    rafaelfranca authored
    Fix migration docs to use new remove_column  semantics
  12. @pftg
  13. @senny

    Merge pull request #12490 from senny/store_accessor_hstore_bug

    senny authored
    ActiveRecord Store works with PG `hstore` columns
  14. @senny

    `ActiveRecord::Store` works together with PG `hstore` columns.

    senny authored
    This is necessary because as of 5ac2341 `hstore` columns are always stored
    as `Hash` with `String` keys. `ActiveRecord::Store` expected the attribute to
    be an instance of `HashWithIndifferentAccess`, which led to the bug.
  15. @senny

    `stored_attributes` need to be specific to a subclass.

    senny authored
    Currently they are all stored globally in the same `Hash`.
    This commit forces the creation of a per-class variable if necessary.
    The behavior was exposed through the following test-case:
      1) Failure:
    StoreTest#test_all_stored_attributes_are_returned [/Users/senny/Projects/rails/activerecord/test/cases/store_test.rb:151]:
    --- expected
    +++ actual
    @@ -1 +1 @@
    -[:color, :homepage, :favorite_food]
    +[:resolution, :color, :homepage, :favorite_food]
  16. @senny
  17. @rafaelfranca

    Merge pull request #12621 from laurocaetano/fix_has_one_association_w…

    rafaelfranca authored
    Save association when primary key is manually set
  18. @laurocaetano
Commits on Oct 24, 2013
  1. @rafaelfranca

    Merge pull request #12636 from kongregate/dont_rescue_Exceptions

    rafaelfranca authored
    Avoid unnecessary catching of Exception instead of StandardError (conver...
  2. @stopdropandrew

    Avoid unnecessary catching of Exception instead of StandardError (con…

    stopdropandrew authored
    …verting Exceptions into StandardErrors)
  3. @rafaelfranca

    Improve the test code for #8422

    rafaelfranca authored
    * Remove unneeded comments.
    * Use key? instead of keys.include?.
  4. @rafaelfranca
  5. @tenderlove

    Merge pull request #12632 from al2o3cr/fix_race_for_attribute_methods

    tenderlove authored
    Always check to see if methods exist after calling define_attribute_methods
  6. @rafaelfranca
  7. @guilleiguaran @rafaelfranca

    Merge pull request #12635 from mperham/4-0-stable

    guilleiguaran authored rafaelfranca committed
    Allow any version of BCrypt
  8. @rafaelfranca

    Merge pull request #10471 from andyw8/button_to_params

    rafaelfranca authored
    Add params option for button_to
  9. @al2o3cr
  10. @rafaelfranca

    Merge pull request #12611 from antonio/slice_bang_honor_default_proc

    rafaelfranca authored
    Make slice! honor default hash value/proc
  11. @rafaelfranca
  12. @rafaelfranca

    Merge pull request #12624 from timsly/master

    rafaelfranca authored
    update CHANGELOG
  13. @guilleiguaran

    Merge pull request #12629 from Peeja/has_many-pets-typo

    guilleiguaran authored
    Fix typo: `has_many :pets`, not `pets :has_many`.
  14. @Peeja
  15. @timsly

    update CHANGELOG

    timsly authored
Something went wrong with that request. Please try again.