Skip to content

Loading…

renamed isNaN warning message property #98

Closed
wants to merge 1 commit into from

1 participant

@ghost

In the check_relation function, there is a call to warn with a 'isnan' argument if the node contains NaN:

warn('isnan', node);

However, the message bundle does not contain a property named 'isnan'. The corresponding message appears in a property named 'isNaN':

bundle = {
    isNaN: "Use the isNaN function to compare with NaN."
};

Validating a line such as var x = 5 > NaN; in the 2012-01-13 edition of http://jslint.com/ results in this message:

Problem at line 1 character 13: isnan

I renamed the property in the message bundle. This makes the name consistent with all other property names, which are lowercase.

@douglascrockford

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 25, 2012
  1. renamed isNaN warning message property, solving #97

    Joost-Wim Boekesteijn committed
Showing with 1 addition and 1 deletion.
  1. +1 −1 jslint.js
View
2 jslint.js
@@ -623,7 +623,7 @@ var JSLINT = (function () {
infix_in: "Unexpected 'in'. Compare with undefined, or use the " +
"hasOwnProperty method instead.",
insecure_a: "Insecure '{a}'.",
- isNaN: "Use the isNaN function to compare with NaN.",
+ isnan: "Use the isNaN function to compare with NaN.",
label_a_b: "Label '{a}' on '{b}' statement.",
lang: "lang is deprecated.",
leading_decimal_a: "A leading decimal point can be confused with a dot: '.{a}'.",
Something went wrong with that request. Please try again.