Add localisations #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match AppKit. I don’t think this is better except for being translated.
Otherwise the folder with the source files in is messy.
Apple does not supply complete Indian English glossaries.
Otherwise the localisations from the framework are not used.
Xcode told me to.
Get output path from environment instead of hardcoding. Make it faster with memoisation.
Merged
douglashill
added a commit
that referenced
this pull request
Mar 28, 2020
This improves the localisations added in #6. This was done by looking at: - the previously generated text - the bar button item accessibility labels - the most common translations across Apple’s strings files - running iOS in many languages and seeing what text is used - dictionaries There is no clear superior source in the Apple translations, but combining the sources of information above with judgment should have resulted in better text. This branch consolidates each of Delete and Refresh to a single entry each since the intended meaning and context is the same. Lastly, the ExtractLocalisedStrings target has been removed because the strings files need heavy manual editing. The script is a tool to assist rather than full automation so including it in this repository does not make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increase the number of localisations from 1 to 39.
The .strings files are generated from Apple localisation glossaries using a script set up as the ExtractLocalisedStrings target and scheme.
The demo app enables all these localisations, although it isn’t localised itself.
One benefit of being able to extract Apple strings files is that bar button item key command titles no longer need to look up the accessibility label using private API.