Skip to content


Subversion checkout URL

You can clone with
Download ZIP


propagate go tool failure #1

merged 1 commit into from

2 participants


goflymake currently succeeds even if go build/go test fail. This seems to cause the version of flymake on my home system to ignore the goflymake output and assume there are no errors.


On closer inspection, my home flymake wasn't checking the error code, I just had a bad process environment in my mac emacs. So this change doesn't fix anything (but it still seems like not a bad idea to me).

@dougm dougm merged commit 27a1b82 into dougm:master

agreed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 2, 2013
  1. @bcully

    propagate go tool failure

    bcully authored
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −1 main.go
6 main.go
@@ -49,7 +49,11 @@ func main() {
cmd := exec.Command("go", args...)
- out, _ := cmd.CombinedOutput()
+ out, err := cmd.CombinedOutput()
+ if err != nil {
+ os.Exit(1)
+ }
Something went wrong with that request. Please try again.