propagate go tool failure #1

merged 1 commit into from Mar 4, 2013


None yet

2 participants

bcully commented Mar 2, 2013

goflymake currently succeeds even if go build/go test fail. This seems to cause the version of flymake on my home system to ignore the goflymake output and assume there are no errors.

bcully commented Mar 3, 2013

On closer inspection, my home flymake wasn't checking the error code, I just had a bad process environment in my mac emacs. So this change doesn't fix anything (but it still seems like not a bad idea to me).

@dougm dougm merged commit 27a1b82 into dougm:master Mar 4, 2013
dougm commented Mar 4, 2013

agreed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment