Doug MacEachern
dougm

Organizations

@jenkinsci @vmware
Jul 13, 2016
dougm commented on pull request vmware/vic#1483
@dougm

lgtm

Jul 13, 2016
dougm commented on issue vmware/vic#742
@dougm

@corrieb it will auto-close when PR #1431 is merged

Jul 13, 2016
dougm commented on pull request vmware/vic#1481
@dougm

lgtm

Jul 13, 2016
dougm commented on pull request vmware/vic#1449
@dougm

lgtm - as long as CI still checks both

Jul 13, 2016
dougm commented on pull request vmware/vic#1453
@dougm

I can't see what this timeout is for, 3 minutes seems too short if it is install related.

Jul 13, 2016
dougm commented on pull request vmware/vic#1453
@dougm

This line should also be switched to log.Errorf, or removed

Jul 13, 2016
dougm commented on pull request vmware/vic#1453
@dougm

This message should be written to os.Stderr

Jul 13, 2016
dougm commented on pull request vmware/vic#1453
@dougm

Let's also avoid writing to 'f' when nil. Above you can start with: logs := []io.Writer{io.Stdout} When os.OpenFile is ok, then: logs = append(f, l…

Jul 13, 2016
dougm commented on pull request vmware/vic#1453
@dougm

This should be inside an } else {, otherwise will panic() in the case where we cannot OpenFile() above.

Jul 13, 2016
dougm commented on pull request vmware/vic#1463
@dougm

lgtm

Jul 13, 2016
dougm commented on pull request vmware/vic#1455
@dougm

@hickeng yes it fixes that panic

Jul 13, 2016
dougm pushed to vcsim at dougm/govmomi
@dougm
Jul 13, 2016
dougm commented on pull request vmware/vic#1454
@dougm

lgtm

Jul 12, 2016
dougm commented on pull request vmware/vic#1456
@dougm

sheep it

Jul 12, 2016
dougm opened pull request vmware/vic#1455
@dougm
vcsim: Avoid NPE in datastore search
1 commit with 5 additions and 0 deletions
Jul 12, 2016
dougm pushed to vcsim at dougm/vic
@dougm
Jul 11, 2016
dougm commented on pull request vmware/vic#1431
@dougm

will fix that

Jul 11, 2016
dougm commented on pull request vmware/vic#1431
@dougm

@fdawg4l In general, we are using the same logic as vmtoolsd, as of this PR. broadcast? You mean the Send(nil) "to let the VMX know we are here"? T…

Jul 11, 2016
dougm commented on pull request vmware/vic#1431
@dougm

Not required for TP3, will hold off on updates/merge, but ready for review.

Jul 11, 2016
dougm opened pull request vmware/vic#1431
@dougm
Guest tools framework improvements
1 commit with 1,001 additions and 114 deletions
Jul 11, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm ef831f6
    Guest tools framework improvements
Jul 11, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm 1194104
    Guest tools framework improvements
Jul 10, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm 6ce14b3
    Guest tools framework improvements
Jul 10, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm 1fbf83e
    Guest tools framework improvements
Jul 10, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm 165418c
    Guest tools framework improvements
Jul 9, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm e003770
    Guest tools framework improvements
Jul 9, 2016
dougm pushed to toolbox at dougm/vic
@dougm
  • @dougm 5452d13
    Guest tools framework improvements
Jul 9, 2016
dougm commented on pull request vmware/vic#1422
@dougm

lgtm

Jul 9, 2016
dougm commented on pull request vmware/vic#1424
@dougm

lgtm

Jul 9, 2016
dougm commented on pull request vmware/vic#1426
@dougm

lgtm