From 225e2e040c5725753eb80a725d3d36878ba9a243 Mon Sep 17 00:00:00 2001 From: Aki Tuomi Date: Thu, 7 Jan 2021 14:57:23 +0200 Subject: [PATCH] auth: Log failure before freeing up request The request got free'd before logging, causing use-after-free access. Broken in cec5a9c92d094d639c49bb83eeb9383ebb231c6f --- src/auth/auth-request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/auth/auth-request.c b/src/auth/auth-request.c index dc45a4003f..9151807dc6 100644 --- a/src/auth/auth-request.c +++ b/src/auth/auth-request.c @@ -305,8 +305,8 @@ void auth_request_fail(struct auth_request *request) auth_request_set_state(request, AUTH_REQUEST_STATE_FINISHED); auth_request_refresh_last_access(request); - auth_request_handler_reply(request, AUTH_CLIENT_RESULT_FAILURE, "", 0); auth_request_log_finished(request); + auth_request_handler_reply(request, AUTH_CLIENT_RESULT_FAILURE, "", 0); } void auth_request_internal_failure(struct auth_request *request)